Skip to content

Fix unValueData memory costing#7617

Merged
zliu41 merged 1 commit intomasterfrom
kwxm/costing/fix-unValueData-memory-usage
Feb 24, 2026
Merged

Fix unValueData memory costing#7617
zliu41 merged 1 commit intomasterfrom
kwxm/costing/fix-unValueData-memory-usage

Conversation

@kwxm
Copy link
Contributor

@kwxm kwxm commented Feb 24, 2026

Fixes #7603.

The slope and intercept for the unValueData memory costing function were the wrong way wrong. This fixes that.

Thanks to @effectfully for pointing this out.

@kwxm kwxm requested review from Unisay and ana-pantilie February 24, 2026 00:21
@kwxm kwxm added Builtins Costing Anything relating to costs, fees, gas, etc. No Changelog Required Add this to skip the Changelog Check labels Feb 24, 2026
Copy link
Contributor

@ana-pantilie ana-pantilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you for fixing this!

Copy link
Member

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@zliu41 zliu41 merged commit 90f65ae into master Feb 24, 2026
15 of 28 checks passed
@zliu41 zliu41 deleted the kwxm/costing/fix-unValueData-memory-usage branch February 24, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Builtins Costing Anything relating to costs, fees, gas, etc. No Changelog Required Add this to skip the Changelog Check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The MEM model of unValueData is wrong by 11x

3 participants