Skip to content

UPLC optimization pass: hoist polymorphic builtins #7779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zliu41 merged 3 commits into from
May 12, 2026
Merged

UPLC optimization pass: hoist polymorphic builtins #7779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e60135
UPLC optimization pass: hoist polymorphic builtins
zliu41 May 12, 2026
e8789a1
Address comments
zliu41 May 12, 2026
e6ffc1a
> and >=
zliu41 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion ...constitution/test/Cardano/Constitution/Validator/Data/GoldenTests/sorted.golden.cbor.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2039
2033
2 changes: 1 addition & 1 deletion ...stitution/test/Cardano/Constitution/Validator/Data/GoldenTests/sorted.golden.large.budget
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ExBudget {exBudgetCPU = ExCPU 401320625, exBudgetMemory = ExMemory 2038256}
ExBudget {exBudgetCPU = ExCPU 398677958, exBudgetMemory = ExMemory 2022256}
33 changes: 10 additions & 23 deletions cardano-constitution/test/Cardano/Constitution/Validator/Data/GoldenTests/sorted.golden.pir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ program
go expectedPredValues))
in
go ds
!ifThenElse : all a. bool -> a -> a -> a
= /\a -> \(b : bool) (x : a) (y : a) -> case a b [y, x]
in
letrec
!euclid : integer -> integer -> integer
Expand Down Expand Up @@ -211,14 +209,9 @@ program
(\(x : integer) (y : integer) -> lessThanInteger x y)
(\(x : integer) (y : integer) ->
lessThanEqualsInteger x y)
(\(x : integer) (y : integer) -> lessThanInteger y x)
(\(x : integer) (y : integer) ->
ifThenElse
{bool}
(lessThanEqualsInteger x y)
False
True)
(\(x : integer) (y : integer) ->
ifThenElse {bool} (lessThanInteger x y) False True)
lessThanEqualsInteger y x)
(\(x : integer) (y : integer) ->
case
(all dead. integer)
Expand Down Expand Up @@ -318,13 +311,8 @@ program
(\(n' : integer) (d' : integer) ->
let
!x : integer = multiplyInteger n d'
!y : integer = multiplyInteger n' d
in
ifThenElse
{bool}
(lessThanEqualsInteger x y)
False
True)))
lessThanInteger (multiplyInteger n' d) x)))
(\(ds : Rational) (ds : Rational) ->
Rational_match
ds
Expand All @@ -336,13 +324,10 @@ program
(\(n' : integer) (d' : integer) ->
let
!x : integer = multiplyInteger n d'
!y : integer = multiplyInteger n' d
in
ifThenElse
{bool}
(lessThanInteger x y)
False
True)))
lessThanEqualsInteger
(multiplyInteger n' d)
x)))
(\(x : Rational) (y : Rational) ->
Rational_match
x
Expand Down Expand Up @@ -380,8 +365,10 @@ program
!bl : list data = unListData eta
!bl' : list data = tailList {data} bl
in
ifThenElse
{Unit -> Rational}
(let
a = Unit -> Rational
in
\(b : bool) (x : a) (y : a) -> case a b [y, x])
(nullList {data} (tailList {data} bl'))
(\(ds : Unit) ->
unsafeRatio
Expand Down
2 changes: 1 addition & 1 deletion ...stitution/test/Cardano/Constitution/Validator/Data/GoldenTests/sorted.golden.small.budget
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ExBudget {exBudgetCPU = ExCPU 58860489, exBudgetMemory = ExMemory 267518}
ExBudget {exBudgetCPU = ExCPU 58843036, exBudgetMemory = ExMemory 267418}
2,265 changes: 1,152 additions & 1,113 deletions cardano-constitution/test/Cardano/Constitution/Validator/Data/GoldenTests/sorted.golden.uplc
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...nstitution/test/Cardano/Constitution/Validator/Data/GoldenTests/unsorted.golden.cbor.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2019
2012
2 changes: 1 addition & 1 deletion ...itution/test/Cardano/Constitution/Validator/Data/GoldenTests/unsorted.golden.large.budget
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ExBudget {exBudgetCPU = ExCPU 565605480, exBudgetMemory = ExMemory 2923191}
ExBudget {exBudgetCPU = ExCPU 562962813, exBudgetMemory = ExMemory 2907191}
33 changes: 10 additions & 23 deletions ...ano-constitution/test/Cardano/Constitution/Validator/Data/GoldenTests/unsorted.golden.pir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ program
go expectedPredValues))
in
go ds
!ifThenElse : all a. bool -> a -> a -> a
= /\a -> \(b : bool) (x : a) (y : a) -> case a b [y, x]
in
letrec
!euclid : integer -> integer -> integer
Expand Down Expand Up @@ -211,14 +209,9 @@ program
(\(x : integer) (y : integer) -> lessThanInteger x y)
(\(x : integer) (y : integer) ->
lessThanEqualsInteger x y)
(\(x : integer) (y : integer) -> lessThanInteger y x)
(\(x : integer) (y : integer) ->
ifThenElse
{bool}
(lessThanEqualsInteger x y)
False
True)
(\(x : integer) (y : integer) ->
ifThenElse {bool} (lessThanInteger x y) False True)
lessThanEqualsInteger y x)
(\(x : integer) (y : integer) ->
case
(all dead. integer)
Expand Down Expand Up @@ -318,13 +311,8 @@ program
(\(n' : integer) (d' : integer) ->
let
!x : integer = multiplyInteger n d'
!y : integer = multiplyInteger n' d
in
ifThenElse
{bool}
(lessThanEqualsInteger x y)
False
True)))
lessThanInteger (multiplyInteger n' d) x)))
(\(ds : Rational) (ds : Rational) ->
Rational_match
ds
Expand All @@ -336,13 +324,10 @@ program
(\(n' : integer) (d' : integer) ->
let
!x : integer = multiplyInteger n d'
!y : integer = multiplyInteger n' d
in
ifThenElse
{bool}
(lessThanInteger x y)
False
True)))
lessThanEqualsInteger
(multiplyInteger n' d)
x)))
(\(x : Rational) (y : Rational) ->
Rational_match
x
Expand Down Expand Up @@ -380,8 +365,10 @@ program
!bl : list data = unListData eta
!bl' : list data = tailList {data} bl
in
ifThenElse
{Unit -> Rational}
(let
a = Unit -> Rational
in
\(b : bool) (x : a) (y : a) -> case a b [y, x])
(nullList {data} (tailList {data} bl'))
(\(ds : Unit) ->
unsafeRatio
Expand Down
2 changes: 1 addition & 1 deletion ...itution/test/Cardano/Constitution/Validator/Data/GoldenTests/unsorted.golden.small.budget
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ExBudget {exBudgetCPU = ExCPU 57466746, exBudgetMemory = ExMemory 259919}
ExBudget {exBudgetCPU = ExCPU 57449293, exBudgetMemory = ExMemory 259819}
Loading
Loading