Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository/tooling from the DecSm naming/org to Invex, updating project/solution references, namespaces, and CI artifact naming so builds and packages align with the new identity.
Changes:
- Renamed the ArtifactClean tool project and namespace from
DecSm.*toInvex.*(including solution references). - Updated build/packaging metadata and CI workflow artifact names/paths to the new project name.
- Added a
dotnet cleaninvocation to theartcleancommand before recursive deletion and optional restore.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates the repo/tool naming to Invex and the project path shown in the structure section. |
| Invex.Tools.slnx | Points the solution at the renamed Invex.Tools.ArtifactClean project path. |
| Invex.Tools.ArtifactClean/Program.cs | Adds the new console app entry point wiring up Commands. |
| Invex.Tools.ArtifactClean/Invex.Tools.ArtifactClean.csproj | Introduces the renamed tool project with AOT/multi-TFM settings and package refs. |
| Invex.Tools.ArtifactClean/Commands.cs | Renames namespace and adds dotnet clean execution prior to recursive deletion/restore. |
| Invex.Tools.ArtifactClean/_usings.cs | Updates global usings to the new namespace and adds CodeAnalysis globals. |
| Directory.Build.props | Updates package metadata (Product, Company) to Invex. |
| .github/workflows/Build.yml | Renames uploaded/downloaded artifact names and paths to Invex.*. |
| _atom/ITargets.cs | Updates the packed tool reference from DecSm_* to Invex_*. |
| _atom/_usings.cs | Adds global JetBrains.Annotations to replace removed file-level usings. |
Comments suppressed due to low confidence (2)
Invex.Tools.ArtifactClean/Commands.cs:16
- The XML doc summary says the command runs
dotnet cleanand then cleans from the specifiedpath, butDotnetClean()currently runs in the process' current working directory (and doesn’t takepath). This can lead to cleaning a different solution than the one being recursively cleaned/restored. Consider passingpathintoDotnetCleanand using it asWorkingDirectory(consistent with the restore process).
Invex.Tools.ArtifactClean/Commands.cs:75 DotnetCleanredirects stdout/stderr but never drains stdout (and only reads stderr afterWaitForExit). With redirected streams this can deadlock ifdotnet cleanwrites enough output to fill the buffer. Either avoid redirection, or consume both streams asynchronously (e.g.,BeginOutputReadLine/BeginErrorReadLineorReadToEndAsync) before/while waiting for exit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.