Skip to content

major: migrate to invex org#6

Merged
DecSmith42 merged 1 commit intomainfrom
chore/migrate
Apr 11, 2026
Merged

major: migrate to invex org#6
DecSmith42 merged 1 commit intomainfrom
chore/migrate

Conversation

@DecSmith42
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings April 11, 2026 02:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the repository/tooling from the DecSm naming/org to Invex, updating project/solution references, namespaces, and CI artifact naming so builds and packages align with the new identity.

Changes:

  • Renamed the ArtifactClean tool project and namespace from DecSm.* to Invex.* (including solution references).
  • Updated build/packaging metadata and CI workflow artifact names/paths to the new project name.
  • Added a dotnet clean invocation to the artclean command before recursive deletion and optional restore.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Updates the repo/tool naming to Invex and the project path shown in the structure section.
Invex.Tools.slnx Points the solution at the renamed Invex.Tools.ArtifactClean project path.
Invex.Tools.ArtifactClean/Program.cs Adds the new console app entry point wiring up Commands.
Invex.Tools.ArtifactClean/Invex.Tools.ArtifactClean.csproj Introduces the renamed tool project with AOT/multi-TFM settings and package refs.
Invex.Tools.ArtifactClean/Commands.cs Renames namespace and adds dotnet clean execution prior to recursive deletion/restore.
Invex.Tools.ArtifactClean/_usings.cs Updates global usings to the new namespace and adds CodeAnalysis globals.
Directory.Build.props Updates package metadata (Product, Company) to Invex.
.github/workflows/Build.yml Renames uploaded/downloaded artifact names and paths to Invex.*.
_atom/ITargets.cs Updates the packed tool reference from DecSm_* to Invex_*.
_atom/_usings.cs Adds global JetBrains.Annotations to replace removed file-level usings.
Comments suppressed due to low confidence (2)

Invex.Tools.ArtifactClean/Commands.cs:16

  • The XML doc summary says the command runs dotnet clean and then cleans from the specified path, but DotnetClean() currently runs in the process' current working directory (and doesn’t take path). This can lead to cleaning a different solution than the one being recursively cleaned/restored. Consider passing path into DotnetClean and using it as WorkingDirectory (consistent with the restore process).
    Invex.Tools.ArtifactClean/Commands.cs:75
  • DotnetClean redirects stdout/stderr but never drains stdout (and only reads stderr after WaitForExit). With redirected streams this can deadlock if dotnet clean writes enough output to fill the buffer. Either avoid redirection, or consume both streams asynchronously (e.g., BeginOutputReadLine/BeginErrorReadLine or ReadToEndAsync) before/while waiting for exit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DecSmith42 DecSmith42 merged commit 8fba9e5 into main Apr 11, 2026
8 checks passed
@DecSmith42 DecSmith42 deleted the chore/migrate branch April 11, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants