fix(chat): saveTurn SQL WHERE 消除 TOCTOU 竞态#32
Merged
Conversation
ON CONFLICT DO UPDATE 加 WHERE owner 兼容条件，归属校验在单条 SQL 内原子完成； rows=0 时抛 AccessDeniedBusinessException，Message 不插入。 Controller 前置校验保留作为 defense-in-depth。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ON CONFLICT DO UPDATE加WHERE "Chat"."userId" IS NULL OR "Chat"."userId" = EXCLUDED."userId"条件，归属校验在单条 SQL 内原子完成rows=0时抛AccessDeniedBusinessException，异常在 Message INSERT 之前抛出，Message 不会被插入lookupOwner校验保留作为 defense-in-depth（快速拦截明显越权）Closes #27
Test plan
SecurityInvariantsTests12 个测试全部通过（./mvnw test -Dtest=SecurityInvariantsTests）ON CONFLICT ... WHERE语法兼容性：PG 9.5+ 支持，项目用 PG 18，无问题🤖 Generated with Claude Code