AxoIncidentBar: perf, ranking-accuracy, and sender-identification fixes#1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AxoCauseAnalyzerranking fixes — severity-tier sort is now the outermost key (aCriticalcandidate is never ranked below anErrorone regardless of burst/ownership/age bonuses); age contribution capped at 7 days so uninitializedRisenUtccannot dominate the score;BurstWindowcutoff clamped againstDateTimeunderflow; candidates with emptyDisplayMessageexcluded.AxoIncidentBarViewperf and diagnostics — polling cadence driven by_analyzer.ActiveCountinstead ofProvider.ActiveMessagesCount(authoritative in all topologies);Tick()always reads state first then conditionally pulls details when any messenger is non-Idle; Serilog (Information/Debug/Warning/Error) replaces the silentcatch { }.SenderDisplayNamebecomes a top-downAttributeNamebreadcrumb (e.g.Station › Drive › Encoder); newIRankableMessage.SenderSymbolcarries the full PLC symbol path (rendered as a mono subtitle +titletooltip on the bar).AxoMessengerRankableAdapterdefaultsSenderSymbolto the messenger symbol so existing call sites compile unchanged.ReadMessageStateAsyncnow batchesRisen/Fallen/Acknowledgedalongside the state triple;ReadDetailsissues its batch ateAccessPriority.Lowto reduce contention with operator-driven traffic.src/core/docs/AxoIncidentBar.mdranking section updated with severity-tier-outermost note, Station/Drive example rewritten to match the new sort order, BLAZOR tab gains a Sender-identification subsection;src/core/docs/CHANGELOG.md0.56.1entry appended; centralCHANGELOG.mdentry added.Test plan
dotnet test src/core/tests/AXOpen.Core.Tests/Messaging/—AxoCauseAnalyzerTests,AxoIncidentBarPresenterTests,AxoMessengerRankableAdapterTestsall green.dotnet build src/core/src/AXOpen.Core.Blazor/— Razor compiles clean with the newSerilogusing andIRankableMessage.SenderSymbolreferences./core/AxoIncidentBar, trigger the Station / Drive / Encoder + Conveyor / Sensor topology and confirm:Station › Drive › Encoder).MessageCode == 0and confirm it is excluded from the bar candidates (still counted by global indicators).ConfigurePolling done. Messengers discovered: Non bar mount andTick: ActiveCount=… TopCause=…per cycle.🤖 Generated with Claude Code