Fix accumulation of failure descriptions and error codes in UpdateDes…#57
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent incorrect accumulation/formatting of failure descriptions and error codes when TcoInspectionGroup updates its comprehensive result, and adjusts PLC unit tests to ensure failure/error strings are cleared between tests.
Changes:
- Updated
TcoInspectionGroup.UpdateComprehensiveResultto avoid prepending a separator when appending failures/error codes to an empty overall result. - Updated unit test setup to clear
FailuresandErrorCodesfields to avoid cross-test contamination. - Added an assertion to verify the overall failures string starts empty before running the description update scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/TcoInspectors/tests/PlcUnitTests/TcoInspectionGroupTests.cs | Clears overall result failure/error strings in [SetUp] and adds an assertion to catch unexpected pre-population. |
| src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspectionGroup/TcoInspectionGroup.TcPOU | Adjusts how failures/error codes are appended during comprehensive result updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+545
to
+555
| IF _refOverallResult.Failures<>'' THEN | ||
| _refOverallResult.Failures := concat(concat(_refOverallResult.Failures,';'), _currentRunResult.Failures); | ||
| ELSE | ||
| _refOverallResult.Failures := _currentRunResult.Failures; | ||
| END_IF; | ||
|
|
||
| IF _refOverallResult.ErrorCodes<>'' THEN | ||
| _refOverallResult.ErrorCodes := concat(concat(_refOverallResult.ErrorCodes,';'),_currentRunResult.ErrorCodes); | ||
| ELSE | ||
| _refOverallResult.ErrorCodes := _currentRunResult.ErrorCodes; | ||
| END_IF; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…criptions method