Skip to content

Conversation

@IonBazan
Copy link
Owner

@IonBazan IonBazan commented Nov 4, 2021

This change fixes #11 - the issue where aliased packages are shown twice in the change list.

This also adds a public getDiff() method that compares two repositories. This can simplify the testing but also allow developers to use this method in their applications.

Before:
image

After:
image

Missing:

  • coverage
  • Mutation coverage

@IonBazan IonBazan added the bug Something isn't working label Nov 4, 2021
@IonBazan IonBazan self-assigned this Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #12 (5433118) into main (e8480dd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #12   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       162       164    +2     
===========================================
  Files             19        18    -1     
  Lines            430       420   -10     
===========================================
- Hits             430       420   -10     
Impacted Files Coverage Δ
src/PackageDiff.php 100.00% <100.00%> (ø)
src/Command/DiffCommand.php 100.00% <0.00%> (ø)
src/Diff/VersionComparator.php 100.00% <0.00%> (ø)
src/Url/BitBucketGenerator.php 100.00% <0.00%> (ø)
src/Formatter/JsonFormatter.php 100.00% <0.00%> (ø)
src/Formatter/MarkdownListFormatter.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8480dd...5433118. Read the comment docs.

@IonBazan IonBazan force-pushed the bugfix/aliased-packages branch 3 times, most recently from df23b2e to 36acd13 Compare November 5, 2021 05:30
@IonBazan IonBazan force-pushed the bugfix/aliased-packages branch from 36acd13 to 5433118 Compare November 5, 2021 05:34
@IonBazan IonBazan marked this pull request as ready for review November 5, 2021 05:36
@IonBazan IonBazan merged commit 0bb9e24 into main Nov 5, 2021
@IonBazan IonBazan deleted the bugfix/aliased-packages branch November 5, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrading one dev version to another may produce duplicate entry

2 participants