Doesn't work properly on Non-English systems

[Cheet4h]

Hey,

I just ran the tool on a folder and got this. Doesn't do anything for about an hour now.

I think I found the problem: In the file "Compact.vb" the process "MyProcess_OuputDataReceived" checks for english output lines. This obviously fails when compact.exe returns german lines, which may pose an issue on other languages, too. Not sure how localized most of them are.

The proper translations seem to be:

"total bytes of data are stored in" -> "Datenbytes insgesamt werden in %i Bytes gespeichert"  

"The compression ratio is" -> "Das Komprimierungsverh„ltnis ist" #note: "„" should be "ä"  

"directories were uncompressed" -> "waren nicht komprimiert" #probably a bad translation on MS' part here, if this is supposed to indicate the number of files that have just been uncompressed. German means "files that were not compressed"  

" Compressing files in" -> "Komprimieren der Dateien in"  

"[OK]" -> "[OK]" #no change here  

" are not compressed." -> "nicht komprimiert." #this will also trigger on the entry for "directories were uncompressed". Maybe move that entry into a nested if-condition here?  

" Listing " ->" Auflisten von "  

I'll try to fix this on my system and create a branch if I get it working. I haven't looked through the whole source to see if there's more checks for localized output. Also, I never worked with VB before >_>

To ultimately fix this and make it available on more languages, the string should probably be put into a database (XML or JSON?) and be loaded upon start of the program.
Getting the System Locale should be possible, although I've only done this in C# before and don't know how to do this in VB. Otherwise you can probably hack it together by checking the copyright notice in the output.

[Makrea]

You seem on the right track.

Works well on PT-PT localization.

[Cheet4h]

Okay, creating a branch doesn't work for me, probably my own fault. Not all too accustomed with GitHub.

I managed to seemingly get it to work with german language by updating the function with german strings. And nesting a condition so it doesn't trigger too often. It probably still needs another nesting since it triggers all the time during analysis, but I'll check that out tomorrow.

What doesn't work and what I currently don't see how to fix is the compressed filecount. Probably checks for things that aren't present in the german output.

Anyway, here's how I changed the function:

Click to Expand

    Private Sub MyProcess_OutputDataReceived _
        (ByVal sender As Object, ByVal e As System.Diagnostics.DataReceivedEventArgs) _
        Handles MyProcess.OutputDataReceived

        AppendOutputText(vbCrLf & e.Data)                                                       'Sends output to the embedded console

        Try

            If e.Data.Contains("Datenbytes insgesamt werden in") Then                        'Gets the output line that contains both the pre- and post-compression folder sizes
                byteComparisonRaw = e.Data
            End If

            If e.Data.Contains("Das Komprimierungsverh") Then                                 'Gets the output line that contains the compression ratio and forces the progress bar to 100% (indirectly due to threading)
                compressFinished = 1
                dirCountProgress = dirCountTotal
                fileCountProgress = fileCountTotal
            End If

            If e.Data.StartsWith(" Komprimieren der Dateien in") Then                                  'Gets each directory that is compressed. Used for the old progressbar.   
                dirCountProgress += 1
            End If

            If e.Data.EndsWith("[OK]") Then                                                     'Gets each file that was successfully compressed OR uncompressed. 
                fileCountProgress += 1
            End If

            If e.Data.EndsWith(" nicht komprimiert.") Then                                     'Gets the output line that identifies the total number of files compressed. 
                If e.Data.Contains("waren nicht komprimiert") Then                            'Gets the output line that identifies that an uncompression event has finished. 
                    dirCountProgress = 0
                    fileCountProgress = fileCountTotal
                    uncompressFinished = 1
                Else
                    byteComparisonRawFilesCompressed = e.Data
                End If
            End If

            If e.Data.StartsWith(" Auflisten von ") Then                                               'Gets the output line that identifies the query folder count
                QdirCountProgress += 1
            End If
        Catch ex As Exception

        End Try

    End Sub

[vient]

Compact.exe uses FormatMessage API with FORMAT_MESSAGE_FROM_HMODULE parameter to output messages. From what I've read on MSDN, it should be possible to resolve all messages in the beginning (run compact.exe, obtain its handle, then use FormatMessage(FORMAT_MESSAGE_FROM_HMODULE, %compact_exe_handle%, %message_id%, 0, ...) and use them instead of hardcoded strings.

[theChaosCoder]

You can force EN language output with:

 [Threading.Thread]::CurrentThread.CurrentUICulture = 'en';  compact.exe ...

[Iridium-IO]

Thanks for all the input! For now I might resolve to use what @theChaosCoder suggested and force the console output strings into english. Since most of the output is numbers anyway, this shouldn't make too much on an impact right?

[Cheet4h]

@theChaosCoder: Can you elaborate on that?

I've looked and tried this yesterday, this is supposed to work in PowerShell after downloading the english help database and then forcing english output with e.g. "[Threading.Thread]::CurrentThread.CurrentUICulture = 'en'; get-help dir"

Sadly this only seems to work with PowerShell commands. Trying to change the output language of compact.exe does not work for me.

[theChaosCoder]

Yes it is a powershell command... should have written that.

It seems that you can not set a CultureInfo for a Process() method. At least I could not find a working solution.

Maybe calling powershell (powershell script) within your code is the easiest solution.

[Iridium-IO]

I've changed the code to use CMD along with the UICulture tag, but I'm honestly not sure that it will help - could you give it a go and see if anything has changed?

[vient]

It didn't help.
I tried to execute chcp 437 in cmd, then run compact.exe /? — it used English instead of Russian, seems like the solution.

[Iridium-IO]

@vient one of the issues with working in English is that you're blind trying to go the other way :) Here's a version using chcp, see if it works?
CompactGUI.zip

[vient]

Now it works fine for me.

There are some strange things like я instead of dots here:

Of 697 files within 27 directories
57 are compressed and 640 are not compressed.
251я524я489 total bytes of data are stored in 247я452я140 bytes.
The compression ratio is 1,0 to 1.

but it doesn't seem to affect your program.

[Iridium-IO]

@vient brilliant :) Those symbols aren't an issue, I patched it a while back to discard any non-numerical characters in those lines :)