-
-
Notifications
You must be signed in to change notification settings - Fork 285
Description
Hi, firstly thanks a lot for writing this cool GUI (yeah I came here from reddit too). I've used compact.exe before but this makes it much easier.
I went to use the explorer integration and I noticed a couple of issues from reading the code.
First, because you're writing to HKCR, it says you need to run as admin first. But you can write to HKCU\Software\Classes instead, and add the menu item for just the current user; then you don't need to ask for admin. (Maybe it could have an option to add it for all users or just the current user, but I'm not sure it's necessary.)
Second, it's writing to the Folder key, where it should really be writing to Directory. Directory is just for "real" directories; Folder also includes drives (which we don't really want to be running it on) and also "virtual" folders like "This PC", "Network", "Control Panel" etc. (which of course just crashes the program if you try opening it from those.)
I can submit a PR if you like.