Week 3 #3
Open
Week 3 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GizmoGrem
reviewed
Nov 10, 2023
| const [loading, setLoading] = useState(false); | ||
| const [showError, setShowError] = useState(false); | ||
| const [searchParams, setSearchParams] = useState<string | null>( | ||
| safeJsonParse(localStorage.savedSearch) |
Collaborator
There was a problem hiding this comment.
если идут сложные вычисления то лучше использовать
(влияет на инициализацию стейта перед первым рендером)
const [searchParams, setSearchParams] = useState<string | null>(()=>
safeJsonParse(localStorage.savedSearch)
}
GizmoGrem
reviewed
Nov 10, 2023
src/App.tsx
Outdated
| const [isDataLoaded, setIsDataLoaded] = useState(false); | ||
| const [itemsPerPage, setItemsPerPage] = useState(30); | ||
| const [currPageNum, setCurrPageNum] = useState( | ||
| (segments[1].length > 5 && Number(segments[1].slice(5))) || null |
GizmoGrem
reviewed
Nov 12, 2023
src/Components/Data/ProductImage.tsx
Outdated
| @@ -0,0 +1,35 @@ | |||
| import { useState, useContext } from 'react'; | |||
| import './ProductImage.css'; | |||
| import { ProductsContext } from '../../context/context'; | |||
Collaborator
There was a problem hiding this comment.
может index? context/context не очень семантично выглядит
GizmoGrem
reviewed
Nov 12, 2023
src/main.tsx
Outdated
| import App from './App'; | ||
| import './index.css'; | ||
| import ErrorBoundary from './Components/ErrorBoundary/ErrorBoundary'; | ||
| import { BrowserRouter } from 'react-router-dom'; |
Collaborator
There was a problem hiding this comment.
порядок зависимостей, обычно с пэкэджей идут в начале
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✋Hello, my dear Reviewer:))
See below at point 5 👇
Task: https://github.com/rolling-scopes-school/tasks/tree/master/react/modules/module03
Screenshot:
Deploy:rss-app-iriva0313-week3.netlify.app
Done 12.11.2023 / deadline 13.11.2023
Score: 100 / 100
-- Verify that the component renders the specified number of cards - Data.test.tsx;
-- Check that an appropriate message is displayed if no cards are present. - HomePage.test.tsx
-- Ensure that the card component renders the relevant card data; -ProductImage.test.tsx, Product.test.tsx
-- Validate that clicking on a card opens a detailed card component;-App.test.tsx
-- Check that clicking triggers an additional API call to fetch detailed information.-App.test.tsx
-- Check that a loading indicator is displayed while fetching data;-ProductPage.test.tsx
-- Make sure the detailed card component correctly displays the detailed card data;-ProductPage.test.tsx
-- Ensure that clicking the close button hides the component.-ProductPage.test.tsx
-- Make sure the component updates URL query parameter when page changes.-Pagination.test.tsx
-- Verify that clicking the Search button saves the entered value to the local storage;-App.test.tsx
-- Check that the component retrieves the value from the local storage upon mounting.-App.test.tsx
-- Ensure that the 404 page is displayed when navigating to an invalid route. - HomePage.test.tsx