Add fix for NPE on encrypt/decrypt#170
Open
coltfred wants to merge 2 commits into
Open
Conversation
skeet70
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #167
There are a couple cases where the cipher.update can return null. One is if the payload is too short for a block and another is to support GCM tag verification in the context of FIPS.
The comment says:
So either way we should guard against it. I wrote a custom provider to use in the test that buffers everything internally just to show that it works if update returns null. Messing with FIPS for testing was something I didn't want to take on.