Open
Conversation
slozier
requested changes
Apr 8, 2026
Contributor
slozier
left a comment
slozier
left a comment
There was a problem hiding this comment.
out works for me. Other name that comes to mind is dist (just noting it, don't have a preference).
As for the "request changes" part of the review. I think the path in eng/steps.yml will also need updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project root directory contains already a folder
packagesfor input dependencies. It also created a directoryPackagefor the packages the project is producing with./make package(output). This is confusing, and it does not match the new code tree naming (lowercase directories). There is alsoeng/packagefor creating the output packages.To make it clearly distinguishable, I renamed
Packagetoout, which is I think the C/C++ convention (or rather, CMake). I am not attached to the name, it can be anything, as long it is notpackageorpackages(or their letter-casing variants), so I am ready to give it any other acceptable name. The output directory is relevant to package maintainers and people building the package for private use (e.g. between releases).Once it is established, I intend to do the same in IronPython.