Separate positional and keyword arguments in CallExpression#1167
Merged
slozier merged 1 commit intoIronLanguages:masterfrom Apr 11, 2021
Merged
Separate positional and keyword arguments in CallExpression#1167slozier merged 1 commit intoIronLanguages:masterfrom
slozier merged 1 commit intoIronLanguages:masterfrom
Conversation
slozier
approved these changes
Apr 11, 2021
Contributor
There was a problem hiding this comment.
Looks good to me! I thought about doing this but was too lazy to go through with it. 😄
Not specifically an issue with this PR, but one thing that was bugging me while I was working on this code was the Arg construct. It doesn't seem particularly useful, especially now that we have split arguments. For example args could just be a list of expressions and we look for StarredExpression. Also GetArgumentInfo is terrible since it creates an Argument whenever call it on an argument that's not simple (and most of the time we're calling it just to check the Kind). Anyway, enough of my rant. 😺
Member
Author
|
Thanks for the rant! Now the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code refactoring of
CallExpression.It came up when I was looking into keyword arguments for metaclasses (#1163), which most likely will have an impact on
CallExpressionas it is now. So before starting with metaclasses, I wanted to get this one out of the way, since it brings a public interface change.