Remove IronPython.Compiler.Ast.Arg

[slozier]

Gets rid of the annoying (to me) Arg construct. 😄

@BCSharp if you have any feedback. Not sure if this will creates merge conflicts with your PR.

[slozier]

Looks like there are some issues with the start/end indices during parsing.

[slozier]

Looks like I also broke:

class test(*[object]): pass

[BCSharp]

@BCSharp if you have any feedback.

I don't care about Arg that much. There are other things that bug me way more.

Not sure if this will creates merge conflicts with your PR.

I does create a merge conflict in CallExpression that is easilly fixable. More importantly, however, the code will not compile because I still use IReadOnlyList<Arg> Keywords in ClassDefinition.

[BCSharp]

Good luck with this! 😄 IReadOnlyCollection should have had CopyTo, just like ICollection has. I suppose ArrayUtils.Insert<T>(T item, IReadOnlyList<T> list) can also do if (list is T[] array) ... to maintain performance .

[slozier]

Unfortunately ArrayUtils.Insert is in the DLR and I didn't want to rev it just for this. I guess as long as we don't start using UnsafeItems all over the place (I don't see why we would) this is fine.

[slozier]

@BCSharp Thanks for the review! All excellent points. I guess I was a bit quick on the merge. 😄