Enable some metaclass tests#1179
Conversation
|
|
||
| try_metaclass(type) | ||
| #try_metaclass(type(Old)) # bug 364938 | ||
| try_metaclass(type(Old)) |
There was a problem hiding this comment.
We could probably just remove any Old related code since it's for old-style classes which no longer exist.
There was a problem hiding this comment.
There is a different code path in a few places between no base classes specified vs. explicit object as a base. The code should compensate for this but I would keep the tests. Admittedly, the names Old/New are misnomers, any ideas for better names?
There was a problem hiding this comment.
Can't think of good names, maybe something with ExplicitBase for the (object) version? We're going to need good comments for this otherwise I may forget about the different code paths and end up getting rid of it if I ever revisit.
This particular line though is identical to the line above since type(Old) is type.
|
Thanks! |
2 participants
No description provided.