Update from_buffer_copy to accept an IBufferProtocol#1405
Merged
slozier merged 3 commits intoIronLanguages:masterfrom Apr 19, 2022
Merged
Update from_buffer_copy to accept an IBufferProtocol#1405slozier merged 3 commits intoIronLanguages:masterfrom
slozier merged 3 commits intoIronLanguages:masterfrom
Conversation
BCSharp
reviewed
Apr 18, 2022
Member
BCSharp
left a comment
There was a problem hiding this comment.
The changes are fine except for WriteSpan used now in several places. The use is OK but the implementation of method itself caught my attention. It is much less efficient than what spans allow. Perhaps it can be rewritten to something like:
internal unsafe void WriteSpan(int offset, ReadOnlySpan<byte> value) {
Span<byte> dest = new Span<byte>((void*)_data, _size).Slice(offset);
value.CopyTo(dest);
GC.KeepAlive(this);
}b411b49 to
101bea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1404