Enable test_numtypes#1424
Merged
slozier merged 8 commits intoIronLanguages:masterfrom Apr 27, 2022
Merged
Conversation
slozier
reviewed
Apr 27, 2022
Contributor
slozier
left a comment
slozier
left a comment
There was a problem hiding this comment.
Seems fine. I guess it matches the behaviour we had before (not that I necessarily like what we do).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this test has never been run on IronPython 3 before — it was still using Python 2 syntax. After upgrading, it exposed some gaps in the operators on the non-Python integers.
I am torn between enabling and not enabling this test by default. It was originally disabled because it "takes way too long". Indeed, it takes about 30 seconds on my rig, which I think means it can be some extra 3 minutes on the CI server. In the end I enabled it because I have some resolver-related tinkering planned ahead and would prefer the test to catch as much mistakes as possible.