You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried a little to get it work on macOS but it was too much effort. If I had the time to work more on sqlite3, I'd rather replace the backend than spend time hacking the current code that is already heavily hacked.
Little bit odd to have isNT returning true on Unix, but the code is already a mess, so looks good to me.
I agree and actually had a commit changing it to isNTorPosix but it did not look cleaner: a lot of code calling isNT is commented out so either the rename would leave it using a function that is no longer there or if comments were renamed too then the code in those block would really look weird as it is doing sometimes some pretty non-Posix stuff. So in the end, I opted for a minimal change hence no rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1483.