Skip to content

Support sqlite3 on Linux#1486

Merged
BCSharp merged 2 commits intoIronLanguages:masterfrom
BCSharp:sql_linux
May 31, 2022
Merged

Support sqlite3 on Linux#1486
BCSharp merged 2 commits intoIronLanguages:masterfrom
BCSharp:sql_linux

Conversation

@BCSharp
Copy link
Copy Markdown
Member

@BCSharp BCSharp commented May 30, 2022

Part of #1483.

@BCSharp
Copy link
Copy Markdown
Member Author

BCSharp commented May 31, 2022

I tried a little to get it work on macOS but it was too much effort. If I had the time to work more on sqlite3, I'd rather replace the backend than spend time hacking the current code that is already heavily hacked.

@BCSharp BCSharp marked this pull request as ready for review May 31, 2022 17:19
@BCSharp BCSharp merged commit c7d0377 into IronLanguages:master May 31, 2022
@BCSharp BCSharp deleted the sql_linux branch May 31, 2022 19:26
Copy link
Copy Markdown
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little bit odd to have isNT returning true on Unix, but the code is already a mess, so looks good to me.

@BCSharp
Copy link
Copy Markdown
Member Author

BCSharp commented May 31, 2022

Little bit odd to have isNT returning true on Unix, but the code is already a mess, so looks good to me.

I agree and actually had a commit changing it to isNTorPosix but it did not look cleaner: a lot of code calling isNT is commented out so either the rename would leave it using a function that is no longer there or if comments were renamed too then the code in those block would really look weird as it is doing sometimes some pretty non-Posix stuff. So in the end, I opted for a minimal change hence no rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants