Execute class body lambda in outer context#1542
Merged
BCSharp merged 2 commits intoIronLanguages:masterfrom Sep 1, 2022
Merged
Execute class body lambda in outer context#1542BCSharp merged 2 commits intoIronLanguages:masterfrom
BCSharp merged 2 commits intoIronLanguages:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #20.
The "outer context" is basically a local context but created outside of the class lambda. I call it "class context" rather than "local context" because, strictly speaking, the class lambda still creates its own local context inside. The content of both class and local contexts is the same, except that the latter contains the
__class__variable, if present. I kept the creation of the local context like this since the machinery to handle it is inScopeStatement, which servers all scope-creating constructs: class, function, comprehensions, generators, and AST root, so it was easier to implement it this way. Besides, having a separate context without__class__may be useful, I remember in the past having to filter__class__out explicitly on some occasions. Perhaps this can be simplified now.Incidentally, this PR removed some old and obscure incompatibly with CPython (
test_sys_getframe); I take it as a sign that the changes are going in the right direction.