Avoid exceptions when loading importlib#1594
Merged
slozier merged 4 commits intoIronLanguages:masterfrom Nov 22, 2022
Merged
Conversation
Member
|
This is fantastic! It was long on my wish list, but I never got time to look into it. |
Contributor
Author
Wish I could somehow avoid more of them. Maybe something could be done to make zipimport.zipimporter light throwing, but unfortunately it's a class and not a function... I guess I diverge from Python and put a light throwing function in sys.path_hooks, but I'm not sure it it helps long term (zipimport got moved to the stdlib in 3.8). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid exceptions when loading importlib. While the exceptions are normally caught, not having them occur in the first place makes for a more pleasant debugging experience. Related to #1590