Skip to content

Update test_open_abplus #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Update test_open_abplus #1851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6834fb
Update test_open_abplus
BCSharp Dec 24, 2024
aee26b4
Skip test_dict.DictTest.est_container_iterator on Mono
BCSharp Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions Tests/modules/system_related/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,20 @@ def test_strerror(self):
elif is_osx:
self.assertEqual(os.strerror(40), "Message too long")


def test_open_abplus(self):
# equivalent to open(self.temp_file, "ab+"), see also test_file.test_open_abplus
fd = os.open(self.temp_file, os.O_APPEND | os.O_CREAT | os.O_RDWR)
try:
f = open(fd, mode="ab+", closefd=False)
f.write(b"abc")
f.seek(0)
self.assertEqual(f.read(2), b"ab")
f.write(b"def")
self.assertEqual(f.read(2), b"")
f.seek(0)
self.assertEqual(f.read(6), b"abcdef")
f.raw.write(b"abcxxxx")
f.raw.seek(0)
self.assertEqual(f.raw.read(2), b"ab")
f.raw.seek(0, 2)
f.raw.write(b"def")
self.assertEqual(f.raw.read(2), b"")
f.raw.seek(0)
self.assertEqual(f.raw.read(), b"abcxxxxdef")
f.close()
finally:
os.close(fd)
Expand Down
6 changes: 4 additions & 2 deletions Tests/test_dict_stdlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@ def load_tests(loader, standard_tests, pattern):
test.test_dict.DictTest('test_oob_indexing_dictiter_iternextitem'),
test.test_dict.DictTest('test_setdefault_atomic'),
]

skip_tests = []
if is_mono:
failing_tests += [
skip_tests += [
test.test_dict.DictTest('test_container_iterator'), # https://github.com/IronLanguages/ironpython3/issues/544
]

return generate_suite(tests, failing_tests)
return generate_suite(tests, failing_tests, skip_tests)

else:
return tests
Expand Down
15 changes: 8 additions & 7 deletions Tests/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,14 +845,15 @@ def test_open_wbplus(self):
f.seek(0)
self.assertEqual(f.read(), b"abdez")


def test_open_abplus(self):
with open(self.temp_file, "ab+") as f:
f.write(b"abc")
f.seek(0)
self.assertEqual(f.read(2), b"ab")
f.write(b"def")
self.assertEqual(f.read(2), b"")
f.seek(0)
self.assertEqual(f.read(6), b"abcdef")
f.raw.write(b"abc")
f.raw.seek(0)
self.assertEqual(f.raw.read(2), b"ab")
f.raw.write(b"def")
self.assertEqual(f.raw.read(2), b"")
f.raw.seek(0)
self.assertEqual(f.raw.read(6), b"abcdef")

run_test(__name__)
Loading