Skip to content

Fix whitespace#2034

Merged
slozier merged 2 commits intoIronLanguages:mainfrom
BCSharp:tasks_targets
Apr 11, 2026
Merged

Fix whitespace#2034
slozier merged 2 commits intoIronLanguages:mainfrom
BCSharp:tasks_targets

Conversation

@BCSharp
Copy link
Copy Markdown
Member

@BCSharp BCSharp commented Apr 9, 2026

Whitespace only. Brings the format from IronLanguages/dlr#324.

@slozier
Copy link
Copy Markdown
Contributor

slozier commented Apr 9, 2026

Should we rename the file to fix the casing while we're at it?

@BCSharp
Copy link
Copy Markdown
Member Author

BCSharp commented Apr 10, 2026

I haven't noticed it, but yes. Another difference is that IronPython uses Project with ToolsVersion="Current", while the DLR uses ToolsVersion="4.0". I think with modern SDK-stype projects it is ignored anyway. Should we get rid of them? Or standardize on one value?

I was also thinking of simply replacing the content of the IronPython Tasks.targets with an <Import> to Tasks.targets in the DLR, and avoid duplicating the file. Shall we do it?

@slozier
Copy link
Copy Markdown
Contributor

slozier commented Apr 10, 2026

I was also thinking of simply replacing the content of the IronPython Tasks.targets with an <Import> to Tasks.targets in the DLR, and avoid duplicating the file. Shall we do it?

Yeah that's fine since we already have some dependencies on the DLR repo. Although it might be interesting to be able to lose those at some point and have the projects be more independent.

@BCSharp
Copy link
Copy Markdown
Member Author

BCSharp commented Apr 10, 2026

Well, if your intention is to further decouple the two repositories, let's not create more dependencies.

@slozier slozier merged commit 15442c6 into IronLanguages:main Apr 11, 2026
16 of 26 checks passed
@BCSharp BCSharp deleted the tasks_targets branch April 11, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants