Make weakref proxies delegate comparison operators#710
Merged
slozier merged 2 commits intoIronLanguages:masterfrom Jan 10, 2020
Merged
Make weakref proxies delegate comparison operators#710slozier merged 2 commits intoIronLanguages:masterfrom
slozier merged 2 commits intoIronLanguages:masterfrom
Conversation
Add slots for all comparison operators which delegate to the object being proxied.
slozier
reviewed
Dec 19, 2019
Contributor
slozier
left a comment
There was a problem hiding this comment.
Looks good to me. Not too familiar with this part of the codebase so hopefully we're not breaking anything!
| #endregion | ||
|
|
||
| //[SlotField] public static PythonTypeSlot __cmp__ = new SlotWrapper(Symbols.Cmp, ProxyType); | ||
| [SlotField] public static PythonTypeSlot __eq__ = new SlotWrapper("__eq__", ProxyType); |
Contributor
There was a problem hiding this comment.
Neat, didn't know about SlotField.
Contributor
|
I finally got around to running some tests, there's a minor issue when creating a proxy of a type that doesn't have rich comparison operators. However I think it should be resolved by #709 since it'll add the operators to the |
Contributor
|
Thanks for the PR! Will merge it in now even though #709 isn't ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add slots for all comparison operators which delegate to the object
being proxied.
Resolves #697