Implement codecs.ignore_errors#711
Merged
slozier merged 1 commit intoIronLanguages:masterfrom Dec 18, 2019
Merged
Conversation
slozier
approved these changes
Dec 18, 2019
Contributor
slozier
left a comment
There was a problem hiding this comment.
Underscore types seem to mostly be used within the exception classes, however I don't have any better suggestions so this works for me. Have you looked at the tests for these in test_codecscallback?
Member
Author
|
I haven't noticed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works, but I feel uneasy about using a type which name starts with an underscore, although the type itself is public. Is it the right way of doing? If not, here is an alternative implementation of
ignore_errors, which I can push in the next commit: