Support __index__ on additional code paths in Bytes/ByteArray construction#950
Merged
slozier merged 4 commits intoIronLanguages:masterfrom Sep 26, 2020
Merged
Support __index__ on additional code paths in Bytes/ByteArray construction#950slozier merged 4 commits intoIronLanguages:masterfrom
slozier merged 4 commits intoIronLanguages:masterfrom
Conversation
slozier
approved these changes
Sep 25, 2020
Contributor
slozier
left a comment
There was a problem hiding this comment.
Looks good to me.
A though that came to be while looking is that int.from_bytes(2, 'big') probably shouldn't work (and indeed it doesn't with CPython). Similarly, there should be no __index__ calls when going through int.from_bytes.
Member
Author
|
Any idea why |
Contributor
|
No idea for the smtp stuff. Looking at the log is seems like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to tweak
bytesconstruction a little again. Apparently, it is not only "always call__bytes__", but also "always call__index__" — except when constructing fromstrorintderived classes…A similar story in
bytearray.