Use separate test directories per framework#983
Use separate test directories per framework#983slozier merged 3 commits intoIronLanguages:masterfrom
Conversation
|
|
||
| def setUp(self): | ||
| self._temporary_dir = os.path.join(self.temp_dir, "IronPython") | ||
| self._temporary_dir = os.path.join(self.temp_dir, "IronPythonTest", clr.TargetFramework.translate(str.maketrans(" ,=", "_--"))) |
There was a problem hiding this comment.
clr.TargetFramework is probably fine. My only thought is if we ever produce an IronPython.dll assembly which is not in sync with the exe (e.g. if we made a net5.0 exe for testing that references the netcoreapp3.1 assemblies) then the whole thing breaks down... Although I wonder if we could just run the netcoreapp3.1 exe using the .NET 5 runtime without producing a different assembly?
There was a problem hiding this comment.
My attitude is that we'll fix it when we get there. The whole framework detection logic is pretty complex and hard to guess in advance for future frameworks. For the scenarios you describe test_env will most likely have to be updated. We will need something like is_net50. Maybe then we can define a dedicated, platform-unique variable that can replace clr.TargetFramework.
The good news is that in the worst case two of the frameworks will share the same test directory, which is easily noticeable and still better than what we have today.
There was a problem hiding this comment.
This will break running the tests with CPython (clr not defined).
2 participants
This is instead marking
test_dynamic_regressionsNotParallelSafe. Probably helps in other places too.