Cleanup dithering conditional and explanation#41
Conversation
Shouldn't change anything because calling resize with float output and a dither_type disregarded the dither_type value anyways.
|
We are at our third PR with discussion about this topic iirc. At this point I think we should split the one-liner into multiple lines and put them into a (possibly internal) function. |
|
This can get squashed into something like Or merge #37 first (tagged as |
Co-authored-by: FichteFoll <fichtefoll2@googlemail.com>
kageru
left a comment
There was a problem hiding this comment.
The tests are fine, but _should_dither is way too enterprise. Just make it a wrapper around the boolean condition that we had before, optionally with some nicer names like you already did here, but don’t give it all those pseudo-optional parameters where only some combinations of them are actually valid.
The order makes a bit more sense now and the ability to use a clip is gone.
Shouldn't change anything because calling resize with float output and a
dither_typedisregarded thedither_typevalue anyways. Reverts some of the changed behavior in #39 and avoids the misleadingshould_ditherbeing true for float sample type.