ISLANDORA-1537: PHP 5.6 Warning in array_traverse_path()#37
ISLANDORA-1537: PHP 5.6 Warning in array_traverse_path()#37DiegoPino merged 2 commits intoIslandora:7.xfrom
Conversation
Notice when using PHP 5.6: Only variable references should be returned by reference in array_traverse_path(). This patch returns a variable with the value of FALSE, rather than returning FALSE itself.
ISLANDORA-1537: PHP 5.6 Warning in array_traverse_path()
|
Hi Pat! Is there a JIRA ticket that goes with this? |
|
https://jira.duraspace.org/browse/ISLANDORA-1537 Patrick D. Dunlavey On Thu, Nov 5, 2015 at 10:45 AM, Melissa Anez notifications@github.com
|
|
Awesome :) You're under a cCLA, so that's about all the help I can be on this ticket - but thanks! |
|
Hi @patdunlavey, i don't want to be a pain 😄 , but for the next time we have a CONTRIBUTING.md that has some guidelines to help us all have a better coding/git/jira experience. That said, we don't officially support PHP 5.6, but i looks like a good catch/simple fix, so i will review your pull during the day or tomorrow morning. Can you assign this JIRA ticket to yourself or do you wan't me to do this? Thanks! |
|
@DiegoPino I don't think I have permission to assign a JIRA ticket. At least I don't see anything that lets me do that. Sorry if I transgressed the contrib guidlines. Will do better next time! |
|
@patdunlavey, np! I will see you get assigned 😃 Thanks a lot |
|
Hmm I can't merge on this, can I be added to this repo? Looks good to me by the way. |
|
@nigelgbanks only committers can merge. https://github.com/Islandora/islandora/wiki/Islandora-Committers tags @manez |
|
I'm not a committer? |
|
Could be something I did wrong - newbie mistake? On Thu, Nov 5, 2015 at 3:02 PM, Nigel Banks notifications@github.com
Pat Dunlavey |
|
@nigelgbanks this happened a couple of months ago: https://github.com/Islandora/islandora/wiki/Islandora-Committers Apparently while you were in GitHub permissions limbo, I guess? |
|
Limbo? Either way can I be added back to the list? Or will we have to go through this voting process? |
|
Hi Nigel, even when a small fix (that looks ok), it's on review by me. I'm not into merging anymore without rechecking and rechecking. Thanks!. |
|
@patdunlavey, looks fine to me (even when 5.6 is not really supported by us…). Does anyone else, @nigelgbanks, @whikloj, @ruebot has some thoughts on this? I will wait a few hours, and if we don't get a no-no i will merge if that is ok with you. Thanks! |
|
Looks good to me. I think the return doc comment still makes sense as well. |
ISLANDORA-1537: PHP 5.6 Warning in array_traverse_path()
|
Thanks @DiegoPino! |
5 participants
Notice when using PHP 5.6: "Only variable references should be returned by reference in array_traverse_path()." This patch returns a variable with the value of FALSE, rather than returning FALSE itself.