Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Address ISLANDORA-1616; Take avantage of new GitHub functionality, an…#137

Merged
manez merged 2 commits intoIslandora:1.xfrom
ruebot:ISLANDORA-1616
Mar 17, 2016
Merged

Address ISLANDORA-1616; Take avantage of new GitHub functionality, an…#137
manez merged 2 commits intoIslandora:1.xfrom
ruebot:ISLANDORA-1616

Conversation

@ruebot
Copy link
Copy Markdown
Member

@ruebot ruebot commented Mar 7, 2016

JIRA Ticket: https://jira.duraspace.org/browse/ISLANDORA-1616

What does this Pull Request do?

Adds a pull request template to take advantage of new GitHub functionality.

We'll use this pull request to sort and final tweaks to the template before I tackle all the remaining Islandora Foundation modules.

What's new?

Pull request template 😄

How should this be tested?

Can't really test it until it is added, and the the first pull request after this should bring it up.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Example:

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

Interest parties

@DiegoPino, @willtp87, and any @Islandora/7-x-1-x-committers interested in providing feedback

…d setup issue templates, and pull request templates for each Islandora Foundation module
@DiegoPino
Copy link
Copy Markdown

👍 cool @ruebot . Looks pretty good 😄

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
* Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)?
* Could this change impact execution of existing code?

# Interest parties
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interest ed parties? (Unless you mean this is more fun than an Interest Group!)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@manez
Copy link
Copy Markdown
Member

manez commented Mar 17, 2016

reviewed in march 17th Committers - merging and unleashing the torrent 😄

manez added a commit that referenced this pull request Mar 17, 2016
Address ISLANDORA-1616; Take avantage of new GitHub functionality, an…
@manez manez merged commit 3a30251 into Islandora:1.x Mar 17, 2016
@ruebot ruebot deleted the ISLANDORA-1616 branch March 17, 2016 18:37
@ruebot
Copy link
Copy Markdown
Member Author

ruebot commented Mar 17, 2016

PREPARE.

@ruebot
Copy link
Copy Markdown
Member Author

ruebot commented Mar 17, 2016

ALL OF THEM.

Islandora/islandora_pathauto#17
Islandora/islandora_pdfjs#17
Islandora/islandora_premis#53
Islandora/islandora_populator#25
Islandora/islandora_scholar#228
Islandora/islandora_simple_workflow#33
Islandora/islandora_solr_facet_pages#27
Islandora/islandora_solr_metadata#43
Islandora/islandora_solr_search#267
Islandora/islandora_solr_views#41
Islandora/islandora_solution_pack_audio#130
Islandora/islandora_solution_pack_book#188
Islandora/islandora_solution_pack_collection#173
Islandora/islandora_solution_pack_compound#104
Islandora/islandora_solution_pack_disk_image#20
Islandora/islandora_solution_pack_entities#96
Islandora/islandora_solution_pack_image#126
Islandora/islandora_solution_pack_large_image#158
Islandora/islandora_solution_pack_newspaper#136
Islandora/islandora_solution_pack_pdf#120
Islandora/islandora_solution_pack_video#124
Islandora/islandora_solution_pack_web_archive#37
Islandora/islandora_usage_stats#49
Islandora/islandora_videojs#29
Islandora/islandora_xacml_editor#130
Islandora/islandora_xml_forms#222
Islandora/islandora_form_fieldpanel#10
Islandora/islandora_xmlsitemap#25
Islandora/objective_forms#44
Islandora/php_lib#39
Islandora/islandora_paged_content#112
Islandora/islandora_openseadragon#62
Islandora/islandora_ocr#70
Islandora/islandora_oai#83
Islandora/islandora_newspaper_batch#13
Islandora/islandora_marcxml#48
islandora-deprecated/islandora_jwplayer#33
Islandora/islandora_importer#96
Islandora/islandora_internet_archive_bookreader#102
Islandora/islandora_fits#54
Islandora/islandora_checksum_checker#36
Islandora/islandora_checksum#34
Islandora/islandora_bookmark#91
Islandora/islandora_book_batch#58
Islandora/islandora_batch#81
Islandora/islandora_bagit#41
islandora-deprecated/islandora_altmetrics#8
Islandora/islandora#648
Islandora/islandora_drupal_filter#18
Islandora/islandora-xacml-policies#3
Islandora/citeproc-php#6
Islandora/internet_archive_bookreader#6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants