Skip to content

Conversation

@endmoseung
Copy link
Contributor

작업 내용

  • 이부분 혹시나 다시 바뀔수도있어서 sticky관련 로직남겨둘게요!

참고 이미지(선택)

화면 기록 2023-01-28 오후 9 01 19

어떤 점을 리뷰 받고 싶으신가요?

작업내용처럼 sticky관련 로직 남겨뒀어요.
그리고 실제 sticky적용하는 로직 273번쨰 줄도 ${}안에 부분 뺴도되는데 그러면 린트에러걸려서 일부러 block으로 남겨뒀어요!

- 이부분 혹시나 다시 바뀔수도있어서 sticky관련 로직남겨둘게요!
@endmoseung endmoseung added the 🧑‍🎨 Style 스타일링 label Jan 28, 2023
@endmoseung endmoseung self-assigned this Jan 28, 2023
@netlify
Copy link

netlify bot commented Jan 28, 2023

Deploy Preview for record-it-dev ready!

Name Link
🔨 Latest commit 0f6641c
🔍 Latest deploy log https://app.netlify.com/sites/record-it-dev/deploys/63d50f0b891104000884662f
😎 Deploy Preview https://deploy-preview-159--record-it-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

<div
className={`${
isInputFocus && isMobile ? 'hidden' : 'sticky'
isInputFocus && isMobile && 'block'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sticky 가 없는데 어떻게 유지돼요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 기존 sticky> block으로 바꾼거에용! 저희 sticky안쓰기로 결정돼서용

Copy link
Member

@sookyeonghwang sookyeonghwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인이용

@sookyeonghwang sookyeonghwang merged commit 94faea4 into develop Jan 29, 2023
@sookyeonghwang sookyeonghwang deleted the FE-164 branch January 29, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧑‍🎨 Style 스타일링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants