[FE-214]feat: Card컴포넌트화 #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-중복 사용됨에 따라 Card컴포넌트화 -TogetherSlider에서 Card컴포넌트로 대체
✅ Deploy Preview for record-it-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Seongtaek-H
approved these changes
Feb 10, 2023
| const navigate = useNavigate() | ||
|
|
||
| const handleClickRecord = (recordId: number) => { | ||
| if (isDragging && setIsDragging) { |
Contributor
Author
There was a problem hiding this comment.
이부분 세인트가 원래 작성한부분에서 dragging을 체크하는데 저는 그부분이 필요없어서 ?연산자로 받고 세인트코드가 작동하도록 했어요
Member
There was a problem hiding this comment.
그럼 setIsDragging을 뺴고 isDragging 으로만 하는게 더 좋을것같습니다
Contributor
Author
There was a problem hiding this comment.
아 그러면 이게 setIsDragging이 ?연산자라서 없을경우도 있기떄문에 저걸 넣었어요!
src/pages/Main/TogetherSlider.tsx
Outdated
| </div> | ||
| isDragging={isDragging} | ||
| setIsDragging={setIsDragging} | ||
| item={item} |
Member
There was a problem hiding this comment.
item 전체를 그냥 내려버리는거보다 Item.colorName, item.iconName 을 내려주는게 더 명확해보입니다
Contributor
Author
There was a problem hiding this comment.
그래야겠네요 이렇게 하면 item이라는 객체에 종속돼서 확장성이 떨어질거같아요
sookyeonghwang
approved these changes
Feb 10, 2023
Comment on lines
+20
to
+27
| interface RecordCategory { | ||
| recordId: number | ||
| title: string | ||
| iconName: string | ||
| iconColor: string | ||
| } | ||
|
|
||
| export interface IMemoryRecord extends RecordCategory { |
| import { useCheckMobile } from '@hooks/useCheckMobile' | ||
| import { useNavigate } from 'react-router-dom' | ||
|
|
||
| interface CardProps { |
Member
There was a problem hiding this comment.
이름은 Card보다는 RecordCard 처럼 구체적이면 훨씬 좋을 것 같아요
Contributor
Author
There was a problem hiding this comment.
이부분 고민했었는데 그게 더 명확해보이네용 확인입니당~
-컴포넌트명 수정 -의존성 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
-중복 사용됨에 따라 Card컴포넌트화
-TogetherSlider에서 Card컴포넌트로 대체
참고 이미지(선택)
어떤 점을 리뷰 받고 싶으신가요?
free하게 남겨주세용~