[FE-224] fix: 마이페이지 검색 QA 버그 픽스 #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for record-it-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Seongtaek-H
approved these changes
Feb 19, 2023
Member
Seongtaek-H
left a comment
Seongtaek-H
left a comment
There was a problem hiding this comment.
확인했습니다.
마이레코드에서 처음에 검색 결과 페이지로 이동하려면 무조건 엔터키를 눌러야하네요? 저는 change 이벤트 발생하면 디바운스 적용 후 바로 이동하는 것으로 생각했는데 정책서랑 TC를 봐도 좀 애매하긴하네요.
endmoseung
approved these changes
Feb 19, 2023
| setIsClickedInput, | ||
| ...props | ||
| }: SearchInputProps) { | ||
| const KEYWORD_MAX_LENGTH = 12 |
Contributor
There was a problem hiding this comment.
저희 이 12는 모두가 하나의 상수로 두고 써야될것같아요
예를들어 우리가 12> 15로 정책이 바뀌면 레코드 추가페이지에서도 수정해야하고, 워터페이지에도 수정해야하니 하나의 상수만 변경해도 모두가 반영되도록하는게 유지보수에 유리할거같아요!
Member
Author
오늘 QA 때 얘기해보고 변경된다면 배포 전에 반영해보도록 하겠습니다 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
참고 이미지(선택)
어떤 점을 리뷰 받고 싶으신가요?