[FE-46]레코드 아이콘 기능 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-레코드 아이콘 상태별로 출력 -아이콘 클릭시 테두리 -AddRecord 안쓰는 변수 제거 -RecordInput 고정 border제거
endmoseung
requested review from
Seongtaek-H and
sookyeonghwang
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sookyeonghwang
approved these changes
Dec 26, 2022
Comment on lines
+16
to
+21
| type IconSource = { | ||
| src: string | ||
| choosed: boolean | ||
| id: number | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
저 이거 궁금했던건데 어떤 것은 type, 어떤 것은 interface던데 무슨 차이로 작성하시는 건가욤?!
Contributor
Author
There was a problem hiding this comment.
아 이부분도 앞으로 말하려고 했는데 props는 저희 전부 interface로 통일하는걸로 할까요 ?
저도 하다보니까 의문이 생겼었어요
Member
There was a problem hiding this comment.
이 부분 저희 우선 각자 적용하고 수요일 회의시간에 정해볼까요??
삼항연산자에서 and연산자로 수정 Co-authored-by: waterglasses <50071076+sukyeongh@users.noreply.github.com>
✅ Deploy Preview for recorditdev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
-기존 index를 사용했던걸 id로 커버 가능해서 수정
-기존에 AddRecordIcon페이지에서 상수를 선언하고 사용하던걸 상수 파일로 분리
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
참고 이미지(선택)
어떤 점을 리뷰 받고 싶으신가요?
AddRecordIcon페이지내에 const로 기본값들이 선언되있는데 이거 constant로 옮겨야할지 ?