[FE=75] feat: 로그인/회원가입 세션 적용으로 인한 로컬스토리지 로직 제거 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for recorditdev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Seongtaek-H
approved these changes
Jan 2, 2023
Member
Seongtaek-H
left a comment
Seongtaek-H
left a comment
There was a problem hiding this comment.
로그인이 되고 나면 브라우저 헤더 쿠키에 세션 ID가 자동으로 저장되는건가요?
이후에 보내는 http request에도 쿠키에 세션 id가 포함되는지 궁금합니다.
쿠키에 있는 세션 ID를 가져와서 axios 헤더에 추가해줄 필요는 없는건가요?
Member
Author
네네 쿠키에 자동으로 저장됩니다. 로직 성공 후 확인해봐야 되겠지만 이후에 보내는 요청에는 헤더에 세션ID가 자동으로 저장되어 보내지는 것으로 알고있습니다 |
endmoseung
approved these changes
Jan 2, 2023
| if (error.response?.status === 401) { | ||
| const { data } = error.response as AxiosResponse | ||
| const loginType = error.response?.config.url?.split('/')[4] | ||
|
|
Contributor
There was a problem hiding this comment.
이런 401도 상수로 에러명 정해서 하는건 어떨까용 ? 개인적 의견입니당 이유는 어떤 에러인지 알 수 있을거같아서용
| }) | ||
| return | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
라우팅으로 데이터 보내주려고 state사용하신거죵
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
참고 이미지(선택)
X
어떤 점을 리뷰 받고 싶으신가요?
없습니다