[FE-95]feat: protectedRoute 쿠키로 구현 #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-쿠키내에 SESSION Value가 없으면 로그인페이지로 리다이렉트
endmoseung
requested review from
Seongtaek-H and
sookyeonghwang
as code owners
✅ Deploy Preview for record-it-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sookyeonghwang
approved these changes
Jan 14, 2023
Member
sookyeonghwang
left a comment
sookyeonghwang
left a comment
There was a problem hiding this comment.
모승 수고하셨습니다 :) 리뷰 댓글 부탁드려요!
src/routes/protectedRoute.tsx
Outdated
Comment on lines
11
to
12
| const value = document.cookie.match('(^|;) ?' + name + '=([^;]*)(;|$)') | ||
| return value ? value[2] : null |
Member
There was a problem hiding this comment.
이거 value가 무슨 뜻인가요?
그리고 value[2]도 어떤것을 뜻하는지 잘 모르겠습니당,,
Contributor
Author
There was a problem hiding this comment.
이부분 변수 바꾸고 value[2]는 상수화 해볼게요
src/routes/router.tsx
Outdated
| path: '/', | ||
| element: ( | ||
| <ProtectedRoute isPublic={true}> | ||
| <ProtectedRoute isPublic={false}> |
Member
There was a problem hiding this comment.
main도 이제 저희 접근할 수 없는건가욤..?
그러면 레코드 추가할 수 있는 페이지가 없다고 느껴집니다!
우선 '/'페이지는 접근을 허용하게 하고 /record/add에 접근할 때 아래처럼 Alert가 보여져야 한다고 생각해요!
Contributor
Author
There was a problem hiding this comment.
이거는 제가 정책서 다시 보고올게요
-protectedRoute를 먹어야되는 컴포넌트 추가 -protectedRoute부분 변수명 알아보기 쉽도록 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
-쿠키내에 SESSION Value가 없으면 로그인페이지로 리다이렉트
참고 이미지(선택)
어떤 점을 리뷰 받고 싶으신가요?
지금 저희 실제 배포환경처럼 isPublic을 false로 줬는데 SESSION을 꼭 쿠키에 넣어주시거나 개발환경에서 임시로 isPublic을 true로 둔뒤 작업하시고 그부분 커밋 안하셔도 좋을것같아용