Skip to content

Conversation

@lposen
Copy link
Collaborator

@lposen lposen commented Mar 28, 2025

Create a config plugin for the sdk

Test

  1. Run npm install in the root folder
  2. cd into *example`
  3. Run npm install
  4. run npx expo prebuild --clean
  5. run npx expo run:ios or npx expo run:android
  6. Once the build is complete and the app is running on your simulator, make sure that the terminal logs withIterable plugin, followed by a long configuration file. That means the config is correct.

@lposen lposen requested a review from Copilot March 31, 2025 23:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Expo config plugin that logs the configuration and returns the unchanged config, allowing the SDK to use the plugin for further customizations.

  • Adds a new config plugin in plugin/src/index.ts that implements the plugin and logs the config.
  • Provides an entry point in app.plugin.js to export the built plugin module.

Reviewed Changes

Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.

File Description
plugin/src/index.ts Implements the withIterable config plugin.
app.plugin.js Exports the built plugin from the plugin/build folder.
Files not reviewed (6)
  • example/android/gradle.properties: Language not supported
  • example/app.json: Language not supported
  • example/ios/Podfile.properties.json: Language not supported
  • example/ios/expopluginexample.xcodeproj/project.pbxproj: Language not supported
  • plugin/tsconfig.json: Language not supported
  • plugin/tsconfig.tsbuildinfo: Language not supported

@lposen lposen requested a review from evantk91 March 31, 2025 23:39
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified that the console log is working properly.

@lposen lposen merged commit 033b3fb into main Apr 1, 2025
@lposen lposen deleted the MOB-11118-create-config-plugin branch April 1, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants