[MOB-11360] remove-apikey #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Dependencies in yarn.lock
… configurations for push notifications and deep links
…ep links sections into concise instructions
…add new commands for opening iOS and Android projects
…endly error display
evantk91
reviewed
May 8, 2025
|
|
||
|
|
||
| <!-- @import "[TOC]" {cmd="toc" depthFrom=2 depthTo=3 orderedList=false} --> | ||
|
|
Contributor
There was a problem hiding this comment.
Seems like there is extra white space. Is this intentional?
evantk91
reviewed
May 8, 2025
| }, | ||
| "dependencies": { | ||
| "@iterable/react-native-sdk": "^2.0.0-beta", | ||
| "@iterable/react-native-sdk": "^2.0.0-beta.1", |
Contributor
There was a problem hiding this comment.
Shouldnt this be 2.0.0-beta? 2.0.0-beta is the local verdaccio version right?
Collaborator
Author
There was a problem hiding this comment.
It should be 2.0.0-beta.1. There are circular dependencies in 2.0.0-beta which make it fail when imported into expo, though it works in the example app for some reason.
evantk91
approved these changes
May 8, 2025
| </Text> | ||
| <Text style={styles.warningText}> | ||
| See the | ||
| <Text style={styles.emphasisTest}> example README</Text> or the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ JIRA ticket(s)
🏕 Description
Removed
apiKeyfrom the props to address concern from security📷 Screenshots
n/a
🧐 Testing
yarn prepare.env.localfile.envinto.env.localYOUR_ITERABLE_API_KEYwith an Iterable API Keynpx expo prebuild --cleanyarn iosto test iosyarn androidto test androidThe app should build and run as expected
📝 Documentation
n/a