[MOB-11401] updates-for-expo-best-practices #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter navigation and clarity
…per expo best practices
evantk91
reviewed
May 8, 2025
| "main": "build/index.js", | ||
| "types": "build/index.d.ts", | ||
| "main": "build/withIterable.js", | ||
| "types": "build/withIterable.d.ts", |
Contributor
There was a problem hiding this comment.
Is this just renaming to follow best practices?
evantk91
reviewed
May 8, 2025
| @@ -1 +1 @@ | |||
| {"root":["./src/index.ts","./src/withdeeplinks.ts","./src/withiterable.types.ts","./src/withstoreconfigvalues.ts","./src/withpushnotifications/index.ts","./src/withpushnotifications/withandroidpushnotifications.constants.ts","./src/withpushnotifications/withandroidpushnotifications.ts","./src/withpushnotifications/withiospushnotifications.constants.ts","./src/withpushnotifications/withiospushnotifications.ts"],"version":"5.8.3"} No newline at end of file | |||
| {"root":["./src/withdeeplinks.ts","./src/withiterable.ts","./src/withiterable.types.ts","./src/withstoreconfigvalues.ts","./src/withpushnotifications/index.ts","./src/withpushnotifications/withandroidpushnotifications.constants.ts","./src/withpushnotifications/withandroidpushnotifications.ts","./src/withpushnotifications/withiospushnotifications.constants.ts","./src/withpushnotifications/withiospushnotifications.ts"],"version":"5.8.3"} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Not sure where this comes from. Can you explain?
Collaborator
Author
There was a problem hiding this comment.
It's automatic. When you change a name of a file or add a file, this updates automatically.
evantk91
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ JIRA ticket(s)
🏕 Description
Updates to conform to expo plugin best practices, as seen here
📷 Screenshots
n/a
🧐 Testing
yarn clean pluginyarn preparenpx expo prebuild --cleanyarn iosoryarn androidThe app should build successfully
📝 Documentation
n/a