-
Notifications
You must be signed in to change notification settings - Fork 0
[MOB-11410] update plugin to improve qlty report #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β¦OB-11410-update-plugin-to-improve-qlty-report
β¦ in Xcode project
β¦ettings extraction
β¦ins in Android push notifications
β¦OB-11410-update-plugin-to-improve-qlty-report
Ayyanchira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| it('should not add a duplicate dependency to the project build.gradle file', () => { | ||
| const buildGradle = ` | ||
| dependencies { | ||
| classpath '${classpath}:${version}' | ||
| }`; | ||
| const result = addProjectDependency(buildGradle, { | ||
| classpath, | ||
| version, | ||
| }); | ||
| expect(countWord(result, classpath)).toBe(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really important ones.. Nice addition!
β¦OB-11410-update-plugin-to-improve-qlty-report
|
Diff Coverage: The code coverage on the diff in this pull request is 100.0%. Total Coverage: This PR will increase coverage by 1.64%. File Coverage Changes
π Help
|
ποΈ JIRA ticket(s)
π Description
Reduced function complexity and file size, as identified by qlty
π· Screenshots
n/a
π§ Testing
yarn preparenpx expo prebuild --cleanyarn iosyarn androidMake sure everything builds and runs
π Documentation
n/a