Skip to content

Conversation

@lposen
Copy link
Collaborator

@lposen lposen commented May 9, 2025

🎟️ JIRA ticket(s)

πŸ• Description

Reduced function complexity and file size, as identified by qlty

πŸ“· Screenshots

n/a

🧐 Testing

  • root: yarn prepare
  • example:
    • npx expo prebuild --clean
    • yarn ios
    • yarn android

Make sure everything builds and runs

πŸ“ Documentation

n/a

@lposen lposen changed the base branch from main to new-MOB-11390-add-git-action-to-run-tests-in-ci May 9, 2025 01:11
@lposen lposen changed the title Mob 11410 update plugin to improve qlty report [MOB-11410] update plugin to improve qlty report May 9, 2025
…OB-11410-update-plugin-to-improve-qlty-report
@lposen lposen marked this pull request as ready for review May 9, 2025 03:01
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +340 to +349
it('should not add a duplicate dependency to the project build.gradle file', () => {
const buildGradle = `
dependencies {
classpath '${classpath}:${version}'
}`;
const result = addProjectDependency(buildGradle, {
classpath,
version,
});
expect(countWord(result, classpath)).toBe(1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really important ones.. Nice addition!

…OB-11410-update-plugin-to-improve-qlty-report
Base automatically changed from new-MOB-11390-add-git-action-to-run-tests-in-ci to main May 9, 2025 22:38
@qlty-cloud-legacy
Copy link

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 1.64%.

File Coverage Changes
Path File Coverage Ξ” Indirect
plugin/src/withPushNotifications/withAndroidPushNotifications.ts 5.6
plugin/src/withPushNotifications/withAndroidPushNotifications.utils.ts 100.0
plugin/src/withPushNotifications/withIosPushNotifications.utils.ts 100.0
πŸ›Ÿ Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@lposen lposen merged commit b57aef0 into main May 9, 2025
12 of 13 checks passed
@lposen lposen deleted the MOB-11410-update-plugin-to-improve-qlty-report branch May 9, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants