[MOB-11120] add-iterable-to-test-app #4

lposen · 2025-03-28T20:58:52Z

Add iterable integration

Test

cd into root folder
run npm install
run npm run prepare
cd into example folder
run npm install
add your iterable api key to the app.json file
run npx expo prebuild --clean
run the app
-- android: npx expo run:android
-- ios: npx expo run: ios
login with your email
you should now see your iterable inbox

Screenshots

android	ios

… peer dependency for Iterable SDK

…elated dependencies

Copilot

Pull Request Overview

This PR integrates Iterable into the test app and adds relevant color constants for styling consistency.

Adds Iterable dependency to iOS podspec and integrates Iterable SDK in the login flow.
Refactors module imports and updates color constants to support Iterable features.
Updates file structure by moving App.tsx into the src folder and removing the old implementation.

Reviewed Changes

Copilot reviewed 12 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ios/ExpoAdapterIterable.podspec	Adds Iterable dependency for React Native integration.
example/src/index.ts	Exports the App component from the updated location.
example/src/constants/index.ts	Re-exports color constants from colors.ts.
example/src/constants/colors.ts	Defines extensive color constants and types for styling.
example/src/Login.tsx	Implements the login screen with Iterable initialization.
example/src/App.tsx	Configures navigation between login and Iterable inbox.
example/index.ts	Updates the entry point to use the new src folder.
example/App.tsx	Removes outdated App implementation.
.github/pull_request_template.md	Adds pull request template with instructions and screenshots.

Files not reviewed (4)

android/src/main/java/expo/modules/adapters/iterable/ExpoAdapterIterableModule.kt: Language not supported
example/package.json: Language not supported
example/tsconfig.json: Language not supported
package.json: Language not supported

example/src/constants/colors.ts

…iterable-to-test-app

…ors type reference

…om/Iterable/iterable-expo-plugin into MOB-11120-add-iterable-to-test-app * 'MOB-11120-add-iterable-to-test-app' of https://github.com/Iterable/iterable-expo-plugin:

Copilot

Pull Request Overview

This PR integrates Iterable into the test app, enabling an in-app Iterable inbox feature. Key changes include adding an Iterable dependency in the iOS podspec, refactoring the file structure to support the new integration, and introducing a new Login component that initializes and sets up Iterable.

Reviewed Changes

Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
ios/ExpoAdapterIterable.podspec	Added dependency on Iterable-React-Native-SDK
example/src/index.ts	Updated export path to load App from the appropriate source directory
example/src/constants/colors.ts	Added comprehensive color constants supporting consistent app theming
example/src/Login.tsx	Introduced a Login component that initializes Iterable and triggers login flow
example/src/App.tsx	Updated App component to conditionally render Iterable inbox or Login
example/index.ts	Modified import path to adapt to the new file structure
example/App.tsx (removed)	Removed obsolete App file
.github/pull_request_template.md	Added pull request template for consistent PR documentation

Files not reviewed (4)

android/src/main/java/expo/modules/adapters/iterable/ExpoAdapterIterableModule.kt: Language not supported
example/package.json: Language not supported
example/tsconfig.json: Language not supported
package.json: Language not supported

Comments suppressed due to low confidence (1)

example/index.ts:3

Ensure that the updated import path correctly references the intended module, as the change from './App' to './src' may lead to naming mismatches if the exported component is not properly aligned.

import App from './src';

Copilot · 2025-04-01T19:22:07Z

example/src/Login.tsx

+  const onPress = () => {
+    Iterable.setEmail(email);
+    setTimeout(() => {
+      onLoggedIn();
+    }, 300);


Using a fixed delay with setTimeout for navigation may cause timing issues on slower devices. Consider using a callback or promise resolution from the Iterable initialization to ensure reliable transition.

Suggested change

const onPress = () => {

Iterable.setEmail(email);

setTimeout(() => {

onLoggedIn();

}, 300);

const onPress = async () => {

Iterable.setEmail(email);

await Iterable.initialize(getApiKey(), new IterableConfig());

onLoggedIn();

…e app dependencies

Copilot

Pull Request Overview

This PR adds Iterable integration to the test app by updating dependencies, reorganizing the project structure, and implementing a login screen that initializes the Iterable SDK.

Updated the iOS podspec to include the Iterable React Native SDK.
Introduced new files in the example app for colors, constants, and login functionality.
Adjusted the app's entry point and removed a dummy App component to streamline the integration.

Reviewed Changes

Copilot reviewed 12 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
ios/ExpoAdapterIterable.podspec	Added dependency for Iterable React Native SDK
example/src/index.ts	Updated export to point to the App component
example/src/constants/{index,colors}.ts	Introduced and organized colors and constants
example/src/Login.tsx	Added Login component for Iterable initialization
example/src/App.tsx	Integrated IterableInbox with conditional rendering
example/index.ts	Updated file import to reflect new project structure
example/App.tsx	Removed outdated App component
.github/pull_request_template.md	Added PR template for documentation and testing guidance

Files not reviewed (4)

example/android/app/src/main/AndroidManifest.xml: Language not supported
example/package.json: Language not supported
example/tsconfig.json: Language not supported
package.json: Language not supported

Comments suppressed due to low confidence (2)

example/src/Login.tsx:80

[nitpick] Consider using onPress instead of onPressOut to ensure a more standard and consistent user interaction for triggering the login action.

onPressOut={onPress}

example/src/Login.tsx:54

[nitpick] Consider replacing the hardcoded 300ms delay with a named constant to improve readability and maintainability.

setTimeout(() => {

evantk91

LGTM. Verified with iOS and android. Just some comments.

evantk91 · 2025-04-02T16:02:01Z

.github/pull_request_template.md

+Please explain the steps needed to verify your change.
+
+## 📝 Documentation
+


Not sure what this file is used for. Can we remove?

It's supposed to give a base template for the pull requests, but it's not working for some reason

evantk91 · 2025-04-02T16:02:57Z

example/android/app/src/main/AndroidManifest.xml

  </queries>
  <application android:name=".MainApplication" android:label="@string/app_name" android:icon="@mipmap/ic_launcher" android:roundIcon="@mipmap/ic_launcher_round" android:allowBackup="true" android:theme="@style/AppTheme" android:supportsRtl="true">
-    <meta-data android:name="ITERABLE_API_KEY" android:value="YOUR_ITERABLE_API_KEY"/>
+    <meta-data android:name="ITERABLE_API_KEY" android:value="be63942e7f1e425b9923c4d86596528c"/>


Looks like API key was accidently pushed up

shoot!!!! i'll disable it

evantk91 · 2025-04-02T16:13:17Z

example/package.json

  "main": "index.ts",
  "scripts": {
-    "start": "expo start",
+    "start": "expo start --dev-client",


What does --dev-client do?

makes sure that it doesn't run with expo go, which cannot work with our app since it requires that you do not use native files (ie: swift, kotlin, etc)

lposen added 4 commits March 27, 2025 21:43

feature: added rn sdk as a peer dependency

09a7e5e

feature: added react native sdk to example and to podspec

a1cf043

feature: added iterable inbox to app

f7ec610

refactor: update Login component to use getApiKey from expo-plugin

d69f522

lposen marked this pull request as ready for review March 28, 2025 21:15

lposen added 4 commits March 28, 2025 14:26

feature: add pull request template for improved PR submissions

08c89b0

chore: update example app start script for development client and add…

9271901

… peer dependency for Iterable SDK

chore: update Podfile.lock to include Iterable-React-Native-SDK and r…

e9e59fb

…elated dependencies

feature: initialize Iterable API context for android

9ae2c44

lposen requested a review from Copilot March 31, 2025 23:40

Copilot AI reviewed Mar 31, 2025

View reviewed changes

example/src/constants/colors.ts Outdated Show resolved Hide resolved

example/src/constants/colors.ts Outdated Show resolved Hide resolved

lposen and others added 3 commits April 1, 2025 11:21

Merge branch 'MOB-11119-create-api-key-generator' into MOB-11120-add-…

dff561e

…iterable-to-test-app

fix: correct typo in outlineLight color definition and update IconCol…

dc7ab3b

…ors type reference

Merge branch 'MOB-11120-add-iterable-to-test-app' of https://github.c…

2e2ff28

…om/Iterable/iterable-expo-plugin into MOB-11120-add-iterable-to-test-app * 'MOB-11120-add-iterable-to-test-app' of https://github.com/Iterable/iterable-expo-plugin:

lposen requested a review from Copilot April 1, 2025 19:21

Copilot AI reviewed Apr 1, 2025

View reviewed changes

refactor: remove IterableApi context initialization and update exampl…

2b27164

…e app dependencies

Base automatically changed from MOB-11119-create-api-key-generator to main April 2, 2025 04:15

lposen requested a review from Copilot April 2, 2025 04:15

Copilot AI reviewed Apr 2, 2025

View reviewed changes

Merge branch 'main' into MOB-11120-add-iterable-to-test-app

1edffd8

evantk91 approved these changes Apr 2, 2025

View reviewed changes

lposen merged commit dbedac0 into main Apr 2, 2025

lposen deleted the MOB-11120-add-iterable-to-test-app branch April 2, 2025 19:36

		Please explain the steps needed to verify your change.

		## 📝 Documentation

[MOB-11120] add-iterable-to-test-app #4

[MOB-11120] add-iterable-to-test-app #4

Uh oh!

Conversation

lposen commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test

Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

evantk91 left a comment

Choose a reason for hiding this comment

Uh oh!

evantk91 Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

evantk91 Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

evantk91 Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lposen commented Mar 28, 2025 •

edited

Loading