Skip to content

[MOB-12251] temporary fix for circular paths, which break expo #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: [SDK-82] New Architecture
merged 1 commit into from
Oct 9, 2025
Merged

[MOB-12251] temporary fix for circular paths, which break expo #734

merged 1 commit into from
Oct 9, 2025

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Oct 9, 2025 •
edited by atlassian bot
Loading

🔹 JIRA Ticket(s) if any

✏️ Description

Fix circular paths

Test

  • pull branch
  • from the command line, run the following (you may be prompted to install things): 
     npx madge --circular --extensions ts ./
  • the result should be that there are no circular dependencies
Screenshot 2025-10-09 at 5 16 17 AM

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Lines Statements Branches Functions
Coverage: 47%
 46.98% (218/464) 22.04% (41/186) 40.38% (63/156)

@qltysh
Copy link

qltysh bot commented Oct 9, 2025

Diff Coverage: The code coverage on the diff in this pull request is 33.3%.

Total Coverage: This PR will decrease coverage by 0.36%.

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@lposen lposen marked this pull request as ready for review October 9, 2025 12:18
Ayyanchira
Ayyanchira approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual circular dependency part looks nice.
Added nit picks for additional commenting of code

src/inApp/classes/IterableInAppManager.ts
Comment on lines -86 to +89
Iterable?.logger?.log('InAppManager.show');
// Iterable?.logger?.log('InAppManager.show');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove these ones.

src/inApp/classes/IterableInAppManager.ts
source: IterableInAppDeleteSource
): void {
Iterable?.logger?.log('InAppManager.remove');
// Iterable?.logger?.log('InAppManager.remove');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented codes can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future PR I'm going to fix the logger and uncomment them. Which is why they're still in there.

@lposen lposen merged commit c11cf70 into new-arch/master Oct 9, 2025
6 of 7 checks passed
@lposen lposen deleted the new-arch/circ-depend branch October 9, 2025 22:52
@lposen lposen mentioned this pull request Oct 14, 2025
Open
@lposen lposen changed the title refactor: temporary fix for circular paths, which break expo [MOB-12251] temporary fix for circular paths, which break expo Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ayyanchira Ayyanchira Ayyanchira approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lposen @Ayyanchira