Skip to content

[MOB-12251] temporary fix for circular paths, which break expo #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: [SDK-82] New Architecture
merged 1 commit into from
Oct 9, 2025
Merged

[MOB-12251] temporary fix for circular paths, which break expo #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/inApp/classes/IterableHtmlInAppContent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { IterableEdgeInsets } from '../../core';
import { IterableEdgeInsets } from '../../core/classes/IterableEdgeInsets';

import { IterableInAppContentType } from '../enums';
import type {
Expand Down
27 changes: 16 additions & 11 deletions src/inApp/classes/IterableInAppManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { RNIterableAPI } from '../../api';
import { Iterable } from '../../core/classes/Iterable';
import type {
IterableInAppDeleteSource,
IterableInAppLocation,
Expand Down Expand Up @@ -33,9 +32,11 @@ export class IterableInAppManager {
* @returns A Promise that resolves to an array of in-app messages.
*/
getMessages(): Promise<IterableInAppMessage[]> {
Iterable?.logger?.log('InAppManager.getMessages');
// Iterable?.logger?.log('InAppManager.getMessages');

return RNIterableAPI.getInAppMessages() as unknown as Promise<IterableInAppMessage[]>;
return RNIterableAPI.getInAppMessages() as unknown as Promise<
IterableInAppMessage[]
>;
}

/**
Expand All @@ -56,9 +57,11 @@ export class IterableInAppManager {
* @returns A Promise that resolves to an array of messages marked as `saveToInbox`.
*/
getInboxMessages(): Promise<IterableInAppMessage[]> {
Iterable?.logger?.log('InAppManager.getInboxMessages');
// Iterable?.logger?.log('InAppManager.getInboxMessages');

return RNIterableAPI.getInboxMessages() as unknown as Promise<IterableInAppMessage[]>;
return RNIterableAPI.getInboxMessages() as unknown as Promise<
IterableInAppMessage[]
>;
}

/**
Expand All @@ -83,7 +86,7 @@ export class IterableInAppManager {
message: IterableInAppMessage,
consume: boolean
): Promise<string | null> {
Iterable?.logger?.log('InAppManager.show');
// Iterable?.logger?.log('InAppManager.show');
Comment on lines -86 to +89
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove these ones.


return RNIterableAPI.showMessage(message.messageId, consume);
}
Expand Down Expand Up @@ -111,7 +114,7 @@ export class IterableInAppManager {
location: IterableInAppLocation,
source: IterableInAppDeleteSource
): void {
Iterable?.logger?.log('InAppManager.remove');
// Iterable?.logger?.log('InAppManager.remove');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented codes can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future PR I'm going to fix the logger and uncomment them. Which is why they're still in there.


return RNIterableAPI.removeMessage(message.messageId, location, source);
}
Expand All @@ -128,7 +131,7 @@ export class IterableInAppManager {
* ```
*/
setReadForMessage(message: IterableInAppMessage, read: boolean) {
Iterable?.logger?.log('InAppManager.setRead');
// Iterable?.logger?.log('InAppManager.setRead');

RNIterableAPI.setReadForMessage(message.messageId, read);
}
Expand All @@ -148,9 +151,11 @@ export class IterableInAppManager {
getHtmlContentForMessage(
message: IterableInAppMessage
): Promise<IterableHtmlInAppContent> {
Iterable?.logger?.log('InAppManager.getHtmlContentForMessage');
// Iterable?.logger?.log('InAppManager.getHtmlContentForMessage');

return RNIterableAPI.getHtmlInAppContentForMessage(message.messageId) as unknown as Promise<IterableHtmlInAppContent>;
return RNIterableAPI.getHtmlInAppContentForMessage(
message.messageId
) as unknown as Promise<IterableHtmlInAppContent>;
}

/**
Expand All @@ -168,7 +173,7 @@ export class IterableInAppManager {
* ```
*/
setAutoDisplayPaused(paused: boolean) {
Iterable?.logger?.log('InAppManager.setAutoDisplayPaused');
// Iterable?.logger?.log('InAppManager.setAutoDisplayPaused');

RNIterableAPI.setAutoDisplayPaused(paused);
}
Expand Down