Skip to content

[SDK-246] card-component#825

Merged
lposen merged 5 commits intoemb-ootb/masterfrom
loren/embedded/SDK-246-card-component
Mar 19, 2026
Merged

[SDK-246] card-component#825
lposen merged 5 commits intoemb-ootb/masterfrom
loren/embedded/SDK-246-card-component

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Mar 17, 2026

🔹 JIRA Ticket(s) if any

✏️ Description

Added card for embedded messages

Tests

  1. Make sure the app is properly set up. Check out the install instructions in example/README.md for me details.
  2. Run the example app. Check out the run instructions in example/README.md for me details.
  3. Login to the app
  4. Click on the embedded tab at the bottom
  5. Select "Card" as the view type
  6. Click "Get messages for placement ids" -- As long as you have embedded messages showing, they should appear here with the card appearance
  7. Test the buttons, actions etc and make sure they work
card.embedded.mov

@lposen lposen changed the title Loren/embedded/SDK-246-card-component [SDK-246] card-component Mar 17, 2026
@github-actions
Copy link

github-actions bot commented Mar 17, 2026

Lines Statements Branches Functions
Coverage: 67%
67.5% (484/717) 53.57% (180/336) 64.4% (161/250)

@qltysh
Copy link

qltysh bot commented Mar 17, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
...edded/components/IterableEmbeddedCard/IterableEmbeddedCard.tsx100.0%
New file Coverage rating: A
...components/IterableEmbeddedCard/IterableEmbeddedCard.styles.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link

qltysh bot commented Mar 17, 2026

All good ✅

@lposen lposen marked this pull request as ready for review March 17, 2026 19:33
Copy link

@franco-zalamena-iterable franco-zalamena-iterable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android approved

@sumeruchat
Copy link

Also tested on iOS LGTM!

Base automatically changed from loren/embedded/SDK-245-banner-component-stretch to emb-ootb/master March 19, 2026 19:08
@lposen lposen merged commit 17deaef into emb-ootb/master Mar 19, 2026
7 of 8 checks passed
@lposen lposen deleted the loren/embedded/SDK-246-card-component branch March 19, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants