-
Notifications
You must be signed in to change notification settings - Fork 43
[SDK-476] Update RN to 0.81 #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
541edb3
c645a17
868a109
4c3fb4c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v20.19.0 | ||
| v20.19.4 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| RNIterable_kotlinVersion=2.1.20 | ||
| RNIterable_minSdkVersion=24 | ||
| RNIterable_targetSdkVersion=35 | ||
| RNIterable_compileSdkVersion=35 | ||
| RNIterable_targetSdkVersion=36 | ||
| RNIterable_compileSdkVersion=36 | ||
| RNIterable_ndkversion=27.1.12297006 | ||
| android.useAndroidX=true | ||
| android.enableJetifier=true |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,5 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.developer.web-browser</key> | ||
| <true/> | ||
| </dict> | ||
| <dict/> | ||
| </plist> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,32 +14,32 @@ | |
| "@react-navigation/native": "^7.1.14", | ||
| "@react-navigation/native-stack": "^7.0.0", | ||
| "@react-navigation/stack": "^7.4.2", | ||
| "react": "19.1.0", | ||
| "react-native": "0.80.3", | ||
| "react-native-gesture-handler": "^2.26.0", | ||
| "react-native-safe-area-context": "^5.4.0", | ||
| "react-native-screens": ">=4.14.0 <4.19.0", | ||
| "react": "19.1.4", | ||
| "react-native": "0.81.6", | ||
| "react-native-gesture-handler": "^2.28.0", | ||
| "react-native-safe-area-context": "^5.6.0", | ||
| "react-native-screens": ">=4.19.0 <4.25.0", | ||
| "react-native-webview": "^13.14.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/core": "^7.25.2", | ||
| "@babel/preset-env": "^7.25.3", | ||
| "@babel/runtime": "^7.25.0", | ||
| "@react-native-community/cli": "19.1.2", | ||
| "@react-native-community/cli-platform-android": "19.1.2", | ||
| "@react-native-community/cli-platform-ios": "19.1.2", | ||
| "@react-native/babel-preset": "0.80.3", | ||
| "@react-native/eslint-config": "0.80.3", | ||
| "@react-native/metro-config": "0.80.3", | ||
| "@react-native/typescript-config": "0.80.3", | ||
| "@react-native-community/cli": "20.0.0", | ||
| "@react-native-community/cli-platform-android": "20.0.0", | ||
| "@react-native-community/cli-platform-ios": "20.0.0", | ||
| "@react-native/babel-preset": "0.81.6", | ||
| "@react-native/eslint-config": "0.81.6", | ||
| "@react-native/metro-config": "0.81.6", | ||
| "@react-native/typescript-config": "0.81.6", | ||
| "@types/jest": "^29.5.13", | ||
| "@types/react": "^19.1.0", | ||
| "@types/react": "^19.1.4", | ||
| "@types/react-test-renderer": "^19.1.0", | ||
| "react-native-builder-bob": "^0.30.2", | ||
| "react-native-dotenv": "^3.4.11", | ||
| "react-test-renderer": "19.1.0" | ||
| "react-test-renderer": "19.1.4" | ||
| }, | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=20" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The root
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's done via .nvmrc in the root package. |
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The debug
AndroidManifest.xmlwas removed andandroid:usesCleartextTraffic="${usesCleartextTraffic}"now lives in the main manifest, butexample/android/app/build.gradledoesn't define amanifestPlaceholdersvalue forusesCleartextTrafficindefaultConfigor per build type. Manifest merger will fail atassembleDebug/assembleRelease. This isn't caught by CI because the Unit Tests workflow only runs Jest — should we add the placeholders per the RN 0.81 template?Also worth adding an
./gradlew assembleDebugstep (and xcodebuild for iOS) to CI so future RN bumps don't ship broken example builds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes come from React Natives Upgrade Helper, which outlines the tasks for updating between RN versions. I also checked in the scaffolding app suggested by react native, and it doesn't have the changes you suggest either. Perhaps the varible comes from RN?
I agree with adding the
assembleDebugstep to the CI, but it's out of scope for this upgrade.