Skip to content

refactor(plugins): use Blob URLs for plugin loading and startup plugin loading #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Its4Nik merged 1 commit into from
Jan 6, 2026
Merged

refactor(plugins): use Blob URLs for plugin loading and startup plugin loading #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/api/src/plugins/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import BaseLogger from "../logger"

const PluginHandler = new PluginHandlerFactory(
DockStatDB._sqliteWrapper,
BaseLogger.getParentsForLoggerChaining()
BaseLogger.spawn("PluginHandler")
)

await PluginHandler.loadAllPlugins()

export default PluginHandler
22 changes: 15 additions & 7 deletions packages/plugin-handler/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ class PluginHandler {
private frontendHandler: PluginFrontendHandler
private actionsHandler: FrontendActionsHandler

constructor(db: DB, loggerParents: string[] = []) {
this.logger = new Logger("PluginHandler", loggerParents)
constructor(db: DB, logger: Logger) {
this.logger = logger
this.logger.debug("Initializing...")

this.DB = db
Expand Down Expand Up @@ -175,9 +175,14 @@ class PluginHandler {
}

public async loadAllPlugins() {
this.logger.info("Loading all plugins")
const plugins = this.table.select(["*"]).all()
const loadedPlugins = this.loadedPluginsMap

this.logger.debug(
`Found ${plugins.length} Plugins in DB & ${loadedPlugins.size} already loaded`
)

const validPlugins = plugins.filter((p): p is DBPluginShemaT => {
if (loadedPlugins.get(p.id as number)) {
return false
Expand All @@ -189,11 +194,12 @@ class PluginHandler {

const imports = await Promise.allSettled(
validPlugins.map(async (plugin) => {
const tempPath = join(tmpdir(), `/dockstat-plugins/plugin-${plugin.id}-${Date.now()}.js`)
this.logger.debug(`Writing plugin ${plugin.id} to ${tempPath}`)
let blobUrl: string | null = null
try {
await Bun.write(tempPath, plugin.plugin)
const { default: mod } = await import(/* @vite-ignore */ tempPath)
const blob = new Blob([plugin.plugin], { type: "text/javascript" })
blobUrl = URL.createObjectURL(blob)

const { default: mod } = await import(/* @vite-ignore */ blobUrl)

mod.id = plugin.id as number

Expand Down Expand Up @@ -232,7 +238,9 @@ class PluginHandler {
this.logger.error(`Failed to import plugin ${plugin.id}: ${err}`)
return null
} finally {
await unlink(tempPath).catch(() => {})
if (blobUrl) {
URL.revokeObjectURL(blobUrl)
}
}
})
)
Expand Down