Proxy host added to dcm and register a set

[Its4Nik]

Summary by Sourcery

Handle host add/remove events in the Docker client manager and expose updated UI slide and table components.

New Features:

• Add SlideContent component to manage animated slide transitions and content rendering in the Slides UI component.

Bug Fixes:

• Ensure worker host IDs are tracked when hosts are created and when host add/remove events are received.

Enhancements:

• Refine Slides and SlidesHeader composition and exports, and re-export the generic Column type alongside the Table component for broader reuse.
• Loosen table render callback typings in the WorkersTable to rely on shared column typing while preserving internal type assertions.
• Add internal event listeners in DockerClientManagerCore to synchronize worker wrapper host sets with host lifecycle events and improve logging around host registration.

[sourcery-ai]

Reviewer's Guide

Introduces an animated SlideContent component and refactors Slides exports, loosens WorkersTable column render typings, and enhances Docker client host tracking by maintaining host ID sets via internal event listeners and updated typings.

Sequence diagram for updated host event handling in DockerClientManagerCore

sequenceDiagram
    actor HostProcess
    participant WorkerWrapper
    participant DockerClientManagerCore as Manager
    participant Logger

    HostProcess->>WorkerWrapper: Emit EventMessage(host:added or host:removed)
    WorkerWrapper->>Manager: messageListener(msg)
    Manager->>Manager: internalListeners(wrapper, msg)
    alt msg.type == host:added
        Manager->>Logger: debug("Received host:added - adding host to Set")
        Manager->>WorkerWrapper: hostIds.add(hostId)
    else msg.type == host:removed
        Manager->>Logger: debug("Received host:removed - deleting host from Set")
        Manager->>WorkerWrapper: hostIds.delete(hostId)
    end
    Manager->>Manager: triggerHooks(msg)
    Manager->>Logger: debug("Triggering hooks for event ...")

Loading

Class diagram for Docker client manager host tracking changes

classDiagram
    class DockerClientManagerCore {
      - workers
      +internalListeners(wrapper, msg)
      +listenForEvents(params)
      +triggerHooks(message)
    }

    class WorkerWrapper {
      +hostIds
      +messageListener
    }

    class Hosts {
    }

    class EventMessage {
      +type
      +ctx
    }

    class DockerClientEvents {
      +host_added(ctx)
      +host_removed(ctx)
      +host_updated(ctx)
      +host_health_changed(ctx)
    }

    DockerClientManagerCore <|-- Hosts
    DockerClientManagerCore "1" o--> "*" WorkerWrapper : manages
    EventMessage --> DockerClientEvents : type keyof EVENTS
    DockerClientManagerCore ..> EventMessage : handles
    WorkerWrapper ..> EventMessage : emits
    DockerClientManagerCore ..> DockerClientEvents : uses typings
    WorkerWrapper --> "*" string : hostIds

Loading

Class diagram for updated UI Slides, SlideContent, Table, and WorkersTable

classDiagram
    class SlideState {
      +activeSlide
      +isCollapsed
      +animationDirection
      +contentHeight
      +contentRefs
    }

    class SlideContent {
      +state SlideState
      +children
      +render()
    }

    class Slides {
      +props SlidesProps
      +render()
    }

    class SlidesHeader {
      +header
      +render()
    }

    class MinimalSlidesHeader {
      +render()
    }

    class Table {
      +data
      +columns Column[]
      +render()
    }

    class Column {
      +key
      +title
      +width
      +sortable
      +filterable
      +align
      +render(value)
    }

    class WorkersTable {
      +workers
      +render()
    }

    Slides --> SlideContent : composes
    Slides --> SlidesHeader : uses
    Slides --> MinimalSlidesHeader : uses
    SlideContent ..> SlideState : uses

    WorkersTable ..> Table : renders
    Table ..> Column : uses
    WorkersTable ..> Column : defines_render_functions

Loading

File-Level Changes

Change	Details	Files
Add animated SlideContent rendering and adjust Slides-related imports/exports.	Introduce SlideContent component using framer-motion with collapse and slide variants driven by shared slide state. Wire SlideContent into Slides component and reorder Slides imports for clarity. Tidy SlidesHeader imports for type-only usage and structure. Simplify Slides exports from the UI components index to only expose Slides and adjust import structure.	packages/ui/src/components/Slides/SlideContent.tsx packages/ui/src/components/Slides/Slides.tsx packages/ui/src/components/Slides/SlidesHeader.tsx packages/ui/src/components/index.ts
Relax UI Table column render typings and expose Column type for reuse.	Remove explicit value parameter types in WorkersTable column render functions and cast inside where necessary to align with more generic Table typings. Export Column type from Table component and re-export it from the UI components index for external consumption.	apps/dockstat/src/components/clients/WorkersTable.tsx packages/ui/src/components/Table/Table.tsx packages/ui/src/components/index.ts
Track host IDs on worker wrappers via centralized Docker client internal event handling and host creation logging.	Invoke a new internalListeners method on each received event message before triggering hooks in DockerClientManagerCore. Implement internalListeners to handle host:added and host:removed events by updating wrapper.hostIds and emitting debug logs. Remove now-noisy debug log of total registered events in triggerHooks. Log host association in Hosts.create when a wrapper and result.id exist before adding the hostId to wrapper.hostIds.	packages/docker-client/src/manager/core.ts packages/docker-client/src/manager/hosts.ts
Extend Docker client typings for host events.	Update DockerClientEvents to include formatting-friendly separation and ensure host:added/host:removed/host:updated typings are aligned, preparing for host:init or related events.	packages/typings/src/docker-client.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 3 issues, and left some high level feedback:

• In internalListeners, the host:init and host:added branches duplicate the same logic; consider extracting a small helper or falling through in the switch to avoid repetition and keep behavior changes synchronized.
• The internalListeners method is declared public but appears to be used only inside DockerClientManagerCore; if it's not meant to be part of the public API, making it private/protected would communicate intent and reduce surface area.
• In WorkersTable, the removal of typed render parameters and the addition of inline as casts suggests the Column typing could be improved; consider tightening the generic Column type so each column’s render callback receives an appropriately typed value without needing explicit casts.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `internalListeners`, the `host:init` and `host:added` branches duplicate the same logic; consider extracting a small helper or falling through in the switch to avoid repetition and keep behavior changes synchronized.
- The `internalListeners` method is declared `public` but appears to be used only inside `DockerClientManagerCore`; if it's not meant to be part of the public API, making it `private`/`protected` would communicate intent and reduce surface area.
- In `WorkersTable`, the removal of typed `render` parameters and the addition of inline `as` casts suggests the `Column` typing could be improved; consider tightening the generic `Column` type so each column’s `render` callback receives an appropriately typed value without needing explicit casts.

## Individual Comments

### Comment 1
<location> `packages/ui/src/components/Slides/SlideContent.tsx:12-16` </location>
<code_context>
+  state: UseSlideReturn
+  children: Record<string, React.ReactNode>
+}) => {
+  const hasContent =
+    state.activeSlide &&
+    children[state.activeSlide] !== null &&
+    children[state.activeSlide] !== undefined
+  const show = hasContent || !state.isCollapsed
+
</code_context>

<issue_to_address>
**suggestion (bug_risk):** Consider making `hasContent` robust to falsy slide keys and using a simpler null check.

The current check `state.activeSlide && children[state.activeSlide] !== null && children[state.activeSlide] !== undefined` will skip valid entries when `activeSlide` is a falsy key (e.g. `""`, "0"). You can avoid relying on key truthiness and simplify the null/undefined check with something like:

```ts
const activeKey = state.activeSlide
const hasContent = activeKey in children && children[activeKey] != null
```

This preserves support for falsy keys and keeps the `null`/`undefined` handling clear.

```suggestion
  const activeKey = state.activeSlide
  const hasContent =
    activeKey in children && children[activeKey] != null
  const show = hasContent || !state.isCollapsed
```
</issue_to_address>

### Comment 2
<location> `packages/docker-client/src/manager/core.ts:598-621` </location>
<code_context>
     wrapper.messageListener = listener
   }

+  public internalListeners(wrapper: WorkerWrapper, msg: EventMessage<keyof EVENTS>) {
+    switch (msg.type) {
+      case "host:init": {
+        this.logger.debug(`Received ${msg.type} - adding host to Set: wrapper.hostIds`)
+        const hostId = (msg.ctx as Parameters<EVENTS["host:added"]>[0]).hostId
+        !wrapper.hostIds.has(hostId) && wrapper.hostIds.add(hostId)
+        break
+      }
+
+      case "host:added": {
+        this.logger.debug(`Received ${msg.type} - adding host to Set: wrapper.hostIds`)
+        const hostId = (msg.ctx as Parameters<EVENTS["host:added"]>[0]).hostId
+        !wrapper.hostIds.has(hostId) && wrapper.hostIds.add(hostId)
+        break
+      }
+
+      case "host:removed": {
+        this.logger.debug(`Received ${msg.type} - removing host from Set: wrapper.hostIds`)
+        const hostId = (msg.ctx as Parameters<EVENTS["host:removed"]>[0]).hostId
</code_context>

<issue_to_address>
**suggestion:** The internal listener switch has duplicated logic and unnecessary `Set` membership checks.

`"host:init"` and `"host:added"` currently share identical behavior, and the `Set.has` checks are unnecessary because `Set.add`/`delete` are idempotent. Combining those cases and relying directly on `add`/`delete` would reduce duplication and avoid future divergence, e.g.:

```ts
public internalListeners(wrapper: WorkerWrapper, msg: EventMessage<keyof EVENTS>) {
  switch (msg.type) {
    case "host:init":
    case "host:added": { 
      const hostId = (msg.ctx as Parameters<EVENTS[typeof msg.type]>[0]).hostId
      this.logger.debug(`Received ${msg.type} - adding host to Set: wrapper.hostIds`)
      wrapper.hostIds.add(hostId)
      break
    }

    case "host:removed": {
      const hostId = (msg.ctx as Parameters<EVENTS["host:removed"]>[0]).hostId
      this.logger.debug("Received host:removed - removing host from Set: wrapper.hostIds")
      wrapper.hostIds.delete(hostId)
      break
    }
  }
}
```

```suggestion
  public internalListeners(wrapper: WorkerWrapper, msg: EventMessage<keyof EVENTS>) {
    switch (msg.type) {
      case "host:init":
      case "host:added": {
        const hostId = (msg.ctx as Parameters<EVENTS[typeof msg.type]>[0]).hostId
        this.logger.debug(`Received ${msg.type} - adding host to Set: wrapper.hostIds`)
        wrapper.hostIds.add(hostId)
        break
      }

      case "host:removed": {
        const hostId = (msg.ctx as Parameters<EVENTS["host:removed"]>[0]).hostId
        this.logger.debug("Received host:removed - removing host from Set: wrapper.hostIds")
        wrapper.hostIds.delete(hostId)
        break
      }
    }
  }
```
</issue_to_address>

### Comment 3
<location> `packages/docker-client/src/manager/core.ts:600-605` </location>
<code_context>

+  public internalListeners(wrapper: WorkerWrapper, msg: EventMessage<keyof EVENTS>) {
+    switch (msg.type) {
+      case "host:init": {
+        this.logger.debug(`Received ${msg.type} - adding host to Set: wrapper.hostIds`)
+        const hostId = (msg.ctx as Parameters<EVENTS["host:added"]>[0]).hostId
+        !wrapper.hostIds.has(hostId) && wrapper.hostIds.add(hostId)
+        break
</code_context>

<issue_to_address>
**suggestion (bug_risk):** `host:init` handler is casting its context as `host:added` which may diverge from the typings.

Here `"host:init"` casts `ctx` as `Parameters<EVENTS["host:added"]>[0]`, even though `"host:init"` has its own typing. This only works because both currently expose `hostId`, but it implicitly ties `"host:init"` to `"host:added"`’s signature and may become incorrect if they diverge. Please use the `"host:init"` event type instead (or `EVENTS[typeof msg.type]` if the cases are merged) to match the actual contract.

```suggestion
      case "host:init": {
        this.logger.debug(`Received ${msg.type} - adding host to Set: wrapper.hostIds`)
        const hostId = (msg.ctx as Parameters<EVENTS["host:init"]>[0]).hostId
        !wrapper.hostIds.has(hostId) && wrapper.hostIds.add(hostId)
        break
      }
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Its4Nik]

@sourcery-ai review

[sourcery-ai]

Hey - I've left some high level feedback:

• In DockerClientManagerCore, internalListeners appears to be an implementation detail of the message listener; consider making it private (or at least not public) and extracting the hostId from msg.ctx via a small helper to avoid duplicating the cast logic in each case branch.
• In WorkersTable, the loosened render typings now rely on multiple value as ... casts; it might be cleaner to adjust the Column/table generic typings so each column’s render callback receives a strongly typed value rather than needing runtime-type casts.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `DockerClientManagerCore`, `internalListeners` appears to be an implementation detail of the message listener; consider making it `private` (or at least not `public`) and extracting the `hostId` from `msg.ctx` via a small helper to avoid duplicating the cast logic in each case branch.
- In `WorkersTable`, the loosened `render` typings now rely on multiple `value as ...` casts; it might be cleaner to adjust the `Column`/table generic typings so each column’s `render` callback receives a strongly typed value rather than needing runtime-type casts.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}