This repository was archived by the owner on Aug 2, 2025. It is now read-only.
Conversation
-------------- .github/workflows/changelog.yml CHANGELOG.md data/database.db package-lock.json package.json
Closed
22 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+219
to
+229
| router.get("/config", async (req, res) => { | ||
| const configPath = path.join(__dirname, "../../config/dockerConfig.json"); | ||
| try { | ||
| const rawData = fs.readFileSync(configPath); | ||
| const jsonData = JSON.parse(rawData.toString()); | ||
| res.status(200).json(jsonData); | ||
| } catch (error) { | ||
| logger.error("Error loading dockerConfig.json: " + error.message); | ||
| res.status(500).json({ error: "Failed to load Docker configuration" }); | ||
| } | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
…ng mermaid diagrams and dependecy-cruiser
| const regex = /(\d+)([smh])/g; | ||
| let match; | ||
|
|
||
| while ((match = regex.exec(interval))) { |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
Comment on lines
+49
to
+94
| router.post("/enable", (req, res) => { | ||
| fs.readFile(passwordBool, "utf8", (err, data) => { | ||
| const password = req.query.password; | ||
| if (err) { | ||
| logger.error("Error reading the file:", err); | ||
| return; | ||
| } | ||
|
|
||
| const isAuthEnabled = data.trim() === "true"; | ||
| if (isAuthEnabled) { | ||
| logger.error( | ||
| "Passowrd Authentication is already enabled, please dactivate it first", | ||
| ); | ||
| return res.status(401).json({ | ||
| message: | ||
| "Passowrd Authentication is already enabled, please dactivate it first", | ||
| }); | ||
| } | ||
|
|
||
| if (!password) { | ||
| return res.status(400).json({ message: "Password is required" }); | ||
| } | ||
|
|
||
| bcrypt.genSalt(saltRounds, (err, salt) => { | ||
| if (err) { | ||
| logger.error("Error generating salt"); | ||
| return res.status(500).json({ message: "Error generating salt" }); | ||
| } | ||
|
|
||
| bcrypt.hash(password, salt, (err, hash) => { | ||
| if (err) { | ||
| logger.error("Error hashing password"); | ||
| return res.status(500).json({ message: "Error hashing password" }); | ||
| } | ||
|
|
||
| const passwordData = { hash, salt }; | ||
| fs.writeFile(passwordFile, JSON.stringify(passwordData), (err) => { | ||
| if (err) | ||
| return res.status(500).json({ message: "Error saving password" }); | ||
| setTrue(); | ||
| res.json({ message: "Authentication enabled" }); | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
Comment on lines
+116
to
+143
| router.post("/disable", (req, res) => { | ||
| const password = req.query.password; | ||
| if (!password) { | ||
| logger.error("Password is required!"); | ||
| return res.status(400).json({ message: "Password is required" }); | ||
| } | ||
|
|
||
| fs.readFile(passwordFile, "utf8", (err, data) => { | ||
| if (err) { | ||
| logger.error("Error reading password"); | ||
| return res.status(500).json({ message: "Error reading password" }); | ||
| } | ||
|
|
||
| const storedData = JSON.parse(data); | ||
| bcrypt.compare(password, storedData.hash, (err, result) => { | ||
| if (err) { | ||
| logger.error("Error validating password"); | ||
| return res.status(500).json({ message: "Error validating password" }); | ||
| } | ||
| if (!result) { | ||
| logger.error("Invalid password"); | ||
| return res.status(401).json({ message: "Invalid password" }); | ||
| } | ||
| setFalse(); | ||
| res.json({ message: "Authentication disabled" }); | ||
| }); | ||
| }); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
Comment on lines
+32
to
+43
| router.get("/latest", (req, res) => { | ||
| db.get( | ||
| "SELECT info FROM data ORDER BY timestamp DESC LIMIT 1", | ||
| (err, row) => { | ||
| if (err) { | ||
| logger.error("Error fetching latest data:", err.message); | ||
| return res.status(500).json({ error: "Internal server error" }); | ||
| } | ||
| res.json(JSON.parse(row.info)); | ||
| }, | ||
| ); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
Comment on lines
+70
to
+83
| router.get("/time/24h", (req, res) => { | ||
| const oneDayAgo = new Date(Date.now() - 24 * 60 * 60 * 1000).toISOString(); | ||
| db.all( | ||
| "SELECT info FROM data WHERE timestamp >= ?", | ||
| [oneDayAgo], | ||
| (err, rows) => { | ||
| if (err) { | ||
| logger.error("Error fetching data from last 24 hours:", err.message); | ||
| return res.status(500).json({ error: "Internal server error" }); | ||
| } | ||
| res.json(formatRows(rows)); | ||
| }, | ||
| ); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| scheduleFetch(); | ||
|
|
||
| // Routes | ||
| app.use("/api", authMiddleware, api); |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
|
||
| // Routes | ||
| app.use("/api", authMiddleware, api); | ||
| app.use("/conf", authMiddleware, conf); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| // Routes | ||
| app.use("/api", authMiddleware, api); | ||
| app.use("/conf", authMiddleware, conf); | ||
| app.use("/auth", authMiddleware, auth); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| app.use("/api", authMiddleware, api); | ||
| app.use("/conf", authMiddleware, conf); | ||
| app.use("/auth", authMiddleware, auth); | ||
| app.use("/data", authMiddleware, data); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| app.use("/conf", authMiddleware, conf); | ||
| app.use("/auth", authMiddleware, auth); | ||
| app.use("/data", authMiddleware, data); | ||
| app.use("/frontend", authMiddleware, frontend); |
Check failure
Code scanning / CodeQL
Missing rate limiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the backend to optimize, well everything.
Documentation needs to be updated