perf: replace management-path locks with moka concurrent cache#114
Merged
Conversation
- Replace server Connection::udp_sessions from AsyncRwLock<HashMap> to moka::future::Cache, removing Weak/upgrade overhead - Replace client socks5_udp_sessions and fwd_udp_sessions from AsyncRwLock<HashMap> to moka::future::Cache - All operations (get/insert/remove/invalidate) are now lock-free Assisted-by: OpenClaw:deepseek-v4-flash
Change Cache<u16, Arc<UdpSession>> back to Cache<u16, Weak<UdpSession>> to break the strong reference cycle that could prevent memory from being freed: Cache -> Arc<UdpSession> -> conn: Connection -> Cache (same internal data) With Weak, the UdpSession lifetime is controlled by the listen task (which holds Arc), not the cache entry. Assisted-by: OpenClaw:deepseek-v4-flash
UdpSession no longer stores . Instead it only keeps a handle (for cleanup) and receives the Connection directly for relay_packet at spawn time. This breaks the strong reference cycle: Cache -> Arc<UdpSession> -> conn: Connection -> Cache Now: Cache -> Arc<UdpSession> -> cache handle (shared ptr) Cache entries are now instead of , eliminating all upgrade() overhead. Assisted-by: OpenClaw:deepseek-v4-flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace management paths with for lock-free concurrent access.