chore: switch to chiseled base image #87
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR switches from standard .NET base images to chiseled (minimal) base images in the Dockerfile for improved security and reduced attack surface.
- Updates the ASP.NET runtime base image to use the
noble-chiseled-extravariant - Updates the SDK build image to use the
noblevariant for consistency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #87 +/- ##
=======================================
Coverage 51.09% 51.09%
=======================================
Files 10 10
Lines 274 274
Branches 38 38
=======================================
Hits 140 140
Misses 127 127
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| # This stage is used when running from VS in fast mode (Default for Debug configuration) | ||
| FROM mcr.microsoft.com/dotnet/aspnet:9.0-noble-chiseled-extra AS base | ||
| USER $APP_UID | ||
| WORKDIR /app |
There was a problem hiding this comment.
[P1] Switching debug stage to chiseled image removes required shell
This stage is explicitly documented as the image used by Visual Studio “fast mode” debugging, but chiseled images intentionally omit /bin/sh and most diagnostic tooling. Visual Studio’s container debugger starts vsdbg with docker exec … /bin/sh -c …; without a shell the attach sequence fails with “executable file not found”, so debugging the sample in fast mode will break. Consider keeping the full aspnet:9.0 image (or installing a shell) for the development stage while still using chiseled images for production.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 1.0.0-alpha.31 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.