Skip to content

Add option to show blobhole on other themes#3439

Merged
cyip92 merged 4 commits intomasterfrom
hira-blobhole
Jun 28, 2024
Merged

Add option to show blobhole on other themes#3439
cyip92 merged 4 commits intomasterfrom
hira-blobhole

Conversation

@Hirame1
Copy link
Copy Markdown
Collaborator

@Hirame1 Hirame1 commented May 12, 2024

image

@Hirame1 Hirame1 added area: black hole area: themes ui improvement This issue is related to UI rearrangement hi-spec Hi Spec, you can pick those area: options labels May 12, 2024
@Hirame1 Hirame1 requested a review from cyip92 May 12, 2024 13:00
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale label Jun 27, 2024
@Hirame1 Hirame1 removed the stale label Jun 27, 2024
Copy link
Copy Markdown
Collaborator

@cyip92 cyip92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor changes ❤️

Comment thread src/components/modals/options/AnimationOptionsModal.vue Outdated
Comment thread src/components/modals/options/AnimationOptionsModal.vue
@Hirame1 Hirame1 requested a review from cyip92 June 28, 2024 11:46
Copy link
Copy Markdown
Collaborator

@cyip92 cyip92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misread the diff when I made one of those comments 🤦

Anyway looks good to me now 👍

@cyip92 cyip92 merged commit aeaa7a3 into master Jun 28, 2024
@cyip92 cyip92 deleted the hira-blobhole branch June 28, 2024 12:06
Rangaz pushed a commit to Rangaz/AntimatterDimensionsWithAchievementRewards that referenced this pull request Jul 6, 2024
* Add option to show blobhole on other themes

* This is fine

* Change for consistency

* I hope you are happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: black hole area: options area: themes hi-spec Hi Spec, you can pick those ui improvement This issue is related to UI rearrangement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants